Skip to content

Conversation

@mattiagiupponi
Copy link
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Oct 23, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @mattiagiupponi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses critical compatibility issues with Python 3.12 by implementing targeted fixes across the codebase. The changes primarily involve updating regular expression definitions to use raw strings for correct interpretation, modernizing Shapely exception handling to align with current library versions, and pinning the setuptools dependency to prevent specific runtime warnings. These adjustments collectively aim to ensure the application's stability and smooth operation within the Python 3.12 environment.

Highlights

  • Python 3.12 Compatibility: This pull request introduces several adjustments to ensure GeoNode remains compatible and stable when running on Python 3.12.
  • Regex Raw String Fixes: Regular expression patterns used in url_path definitions across various view files (assets, base API, layers API) have been updated to use raw strings (prefixed with r). This prevents potential issues with backslash interpretation in newer Python versions.
  • Shapely Exception Handling Update: The geonode/catalogue/backends/pycsw_local.py file has been updated to catch the more general ShapelyError instead of the deprecated WKBReadingError and WKTReadingError, ensuring compatibility with newer versions of the Shapely library.
  • Setuptools Version Pinning: The setuptools dependency in requirements.txt and setup.cfg has been explicitly pinned to versions less than 80. This is a targeted fix to avoid known runtime warnings related to the polymorphic model when running with Python 3.12.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several important fixes for Python 3.12 compatibility. The changes correctly address DeprecationWarnings for invalid escape sequences in regular expressions by converting them to raw strings. Additionally, it updates the exception handling for the shapely library to use the new ShapelyError, which is a necessary change for newer versions. The version pinning for setuptools is a practical solution to avoid runtime warnings. Overall, these are good changes that improve the project's compatibility with modern Python versions. I have a couple of minor suggestions for code cleanup.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.00%. Comparing base (10d2773) to head (0e9900e).

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #13660       +/-   ##
===========================================
+ Coverage   59.75%   74.00%   +14.25%     
===========================================
  Files         931      931               
  Lines       55148    55148               
  Branches     7427     7427               
===========================================
+ Hits        32952    40815     +7863     
+ Misses      20719    12712     -8007     
- Partials     1477     1621      +144     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants