-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Minor fix for python3.12 #13660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Minor fix for python3.12 #13660
Conversation
Summary of ChangesHello @mattiagiupponi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical compatibility issues with Python 3.12 by implementing targeted fixes across the codebase. The changes primarily involve updating regular expression definitions to use raw strings for correct interpretation, modernizing Shapely exception handling to align with current library versions, and pinning the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several important fixes for Python 3.12 compatibility. The changes correctly address DeprecationWarnings for invalid escape sequences in regular expressions by converting them to raw strings. Additionally, it updates the exception handling for the shapely library to use the new ShapelyError, which is a necessary change for newer versions. The version pinning for setuptools is a practical solution to avoid runtime warnings. Overall, these are good changes that improve the project's compatibility with modern Python versions. I have a couple of minor suggestions for code cleanup.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13660 +/- ##
===========================================
+ Coverage 59.75% 74.00% +14.25%
===========================================
Files 931 931
Lines 55148 55148
Branches 7427 7427
===========================================
+ Hits 32952 40815 +7863
+ Misses 20719 12712 -8007
- Partials 1477 1621 +144 🚀 New features to boost your workflow:
|
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.