Feat/extensions #272
Open
Feat/extensions #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b-Front into feat/extensions
BotellaA
reviewed
Nov 27, 2025
BotellaA
reviewed
Dec 1, 2025
app/stores/app.js
Outdated
| return loadedExtensions.value.get(path) | ||
| } | ||
|
|
||
| async function loadExtension(path, codeTransformer = null) { |
Member
There was a problem hiding this comment.
Est-ce que le transformer doit être donné par l'extension ou fourni par OGW?
app/stores/app.js
Outdated
| } | ||
|
|
||
| if (typeof extensionModule.install === 'function') { | ||
| await extensionModule.install(extensionAPI.value, path) |
Member
There was a problem hiding this comment.
Tu as besoin de path lors du install ? Ça 'r me semble pas approprié
BotellaA
approved these changes
Dec 1, 2025
BotellaA
reviewed
Dec 1, 2025
app/stores/app.js
Outdated
| } | ||
|
|
||
| if (typeof extensionModule.install === 'function') { | ||
| await extensionModule.install(extensionAPI.value, extensionId) |
Member
There was a problem hiding this comment.
Suggested change
| await extensionModule.install(extensionAPI.value, extensionId) | |
| await extensionModule.install(extensionAPI.value) |
as-t-on besoin de l'id ici? au final, on va dans l'extension, elle connait son id. Pas besoin de devoir la passer en paramètre à install non ?
…b-Front into feat/extensions
…OpenGeodeWeb-Front into feat/extensions
…nd placeholder based on focus state
…OpenGeodeWeb-Front into feat/extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.