chore(core, llc): skip generating freezed map and when options #2334

xsahil03x · 2025-07-25T17:21:58Z

Description of the pull request

This PR removes the map and when options from the freezed builder in the build.yaml files for stream_chat and stream_chat_flutter_core.

Summary by CodeRabbit

Chores
- Updated build configurations to adjust settings for code generation tools, ensuring consistency across packages. No user-facing changes.
Refactor
- Simplified and restructured message and upload state handling with improved serialization and equality support.
- Streamlined poll voting mode classes for clearer structure and reduced complexity.

This commit removes the `map` and `when` options from the `freezed` builder in the `build.yaml` files for `stream_chat` and `stream_chat_flutter_core`.

coderabbitai · 2025-07-25T17:22:06Z

Caution

Review failed

The head commit changed during the review from f8af310 to 077aa6e.

Walkthrough

Build configuration files for the stream_chat and stream_chat_flutter_core packages were updated. The freezed builder was configured in both packages to set the map and when options to false. Generated model code for attachment_file, message_state, and poll_voting_mode was extensively refactored to remove pattern matching methods, convert union types to concrete classes, and simplify copyWith implementations. Corresponding JSON serialization functions were renamed to align with public class interfaces.

Changes

File(s)	Change Summary
packages/stream_chat/build.yaml	Updated `freezed` builder options: set `map` and `when` to `false`.
packages/stream_chat_flutter_core/build.yaml	Added new build config: set `freezed` builder `map` and `when` to `false`.
packages/stream_chat/lib/src/core/models/attachment_file.freezed.dart	Refactored `UploadState` union: removed pattern matching, converted to concrete classes, simplified copyWith.
packages/stream_chat/lib/src/core/models/attachment_file.g.dart	Renamed JSON serialization functions to use public class names instead of private implementations.
packages/stream_chat/lib/src/core/models/message_state.freezed.dart	Regenerated and restructured message state unions: removed pattern matching, converted to concrete classes, added copyWith.
packages/stream_chat/lib/src/core/models/message_state.g.dart	Renamed JSON serialization functions to use public class names instead of private implementations.
packages/stream_chat/lib/src/core/models/poll_voting_mode.freezed.dart	Simplified `PollVotingMode` union: removed pattern matching, private implementations, and most copyWith methods; retained minimal copyWith on `VotingLimited`.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~40 minutes

Poem

A bunny hops through code so wide,
Unwrapping unions, no need to hide.
Pattern matches gently swept away,
Concrete classes now hold their sway.
Builders tuned with YAML care,
Clean and clear, beyond compare! 🐇✨

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/skip-generating-map-when

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/stream_chat_flutter_core/build.yaml (1)
1-7: Add a trailing newline to pass YAML-lint and POSIX tools

The file lacks a newline at EOF (new-line-at-end-of-file), which some linters and POSIX utilities expect.
-          when: false
+          when: false
+
packages/stream_chat/build.yaml (1)
7-11: Add a trailing newline to satisfy linters

Same new-line-at-end-of-file warning here.
-          when: false
+          when: false
+

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab6554c and c269be2.

📒 Files selected for processing (2)

packages/stream_chat/build.yaml (1 hunks)
packages/stream_chat_flutter_core/build.yaml (1 hunks)

🧰 Additional context used

🪛 YAMLlint (1.37.1)

packages/stream_chat_flutter_core/build.yaml

[error] 7-7: no new line character at the end of file

(new-line-at-end-of-file)

packages/stream_chat/build.yaml

[error] 11-11: no new line character at the end of file

(new-line-at-end-of-file)

packages/stream_chat_flutter_core/build.yaml

codecov · 2025-07-25T17:30:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (ab6554c) to head (077aa6e).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2334   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files         409      409           
  Lines       25617    25617           
=======================================
  Hits        16306    16306           
  Misses       9311     9311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xsahil03x · 2025-07-28T09:49:17Z

@coderabbitai review

coderabbitai · 2025-07-28T09:49:23Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chore(core, llc): remove freezed map and when options

c269be2

This commit removes the `map` and `when` options from the `freezed` builder in the `build.yaml` files for `stream_chat` and `stream_chat_flutter_core`.

coderabbitai bot reviewed Jul 25, 2025

View reviewed changes

packages/stream_chat_flutter_core/build.yaml Show resolved Hide resolved

chore: regenerate files

077aa6e

xsahil03x force-pushed the chore/skip-generating-map-when branch from f8af310 to 077aa6e Compare July 25, 2025 18:21

xsahil03x requested a review from renefloor July 25, 2025 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(core, llc): skip generating freezed map and when options #2334

chore(core, llc): skip generating freezed map and when options #2334

Uh oh!

xsahil03x commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codecov bot commented Jul 25, 2025 •

edited

Loading

Uh oh!

xsahil03x commented Jul 28, 2025

Uh oh!

coderabbitai bot commented Jul 28, 2025

Uh oh!

Uh oh!

chore(core, llc): skip generating freezed map and when options #2334

Are you sure you want to change the base?

chore(core, llc): skip generating freezed map and when options #2334

Uh oh!

Conversation

xsahil03x commented Jul 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the pull request

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xsahil03x commented Jul 28, 2025

Uh oh!

coderabbitai bot commented Jul 28, 2025

Uh oh!

Uh oh!

xsahil03x commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jul 25, 2025 •

edited

Loading