Skip to content

[Fix]Unnecessary calls to updateSubscriptions #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Fix]Unnecessary calls to updateSubscriptions #795

wants to merge 1 commit into from

Conversation

ipavlidakis
Copy link
Contributor

🔗 Issue Links

Resolves https://linear.app/stream/issue/IOS-837/stop-making-unnecessary-calls-to-update-subscriptions

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the bug Something isn't working label May 2, 2025
@ipavlidakis ipavlidakis self-assigned this May 2, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner May 2, 2025 11:11
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

Public Interface

🚀 No changes affecting the public interface.

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamVideo 7.54 MB 7.54 MB +1 KB 🟢
StreamVideoSwiftUI 2.25 MB 2.25 MB 0 KB 🟢
StreamVideoUIKit 2.38 MB 2.38 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
87.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

martinmitrevski
martinmitrevski reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I want to test it on few calls before we merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ipavlidakis ipavlidakis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski