Skip to content

Fix #43 Include language xml in nuget package. Remove from sandbox #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #43 Include language xml in nuget package. Remove from sandbox #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
135 changes: 0 additions & 135 deletions sandbox/Foundation/src/Foundation/lang/geta.epicategories.xml
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions src/Geta.Optimizely.Categories/Geta.Optimizely.Categories.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@
<Content Remove="module\module.config" />
</ItemGroup>

<ItemGroup>
<EmbeddedResource Include="lang\geta.epicategories.xml" />
</ItemGroup>
Comment on lines +32 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a comment explaining why this XML file is being included as an embedded resource. This will help future developers understand the purpose of this configuration.

    <EmbeddedResource Include="lang\geta.epicategories.xml"> 
      <!-- Includes the language XML file for localization -->
    </EmbeddedResource>


<ItemGroup>
<None Include="module\module.config" />
<None Include="msbuild\Main.proj" />
Expand Down