Open
Conversation
| #include "data/encoding/endian/arithmetic.hpp" | ||
| #include "address.hpp" | ||
| namespace Gigamonkey::Bitcoin::P2P { | ||
| struct NodeAddress { |
Contributor
There was a problem hiding this comment.
types have lower cases names like "node_address". Does it need node? Could it simply be called "address" ?
| data::int32_little timestamp{}; | ||
| }; | ||
|
|
||
| class AbstractAddressManager { |
Contributor
There was a problem hiding this comment.
Don't name things "Abstract..." please just "address_manager"
| std::string IpAddress{}; | ||
| data::uint16_big port{}; | ||
| data::uint64_little services{}; | ||
| data::int32_little timestamp{}; |
Contributor
There was a problem hiding this comment.
Why would addresses include services and timestamp? That's not an address. Also this supports ipv6 right? We want to do everything on ipv6 in Bitcoin eventually.
| #include "data/cross.hpp" | ||
| #include "gigamonkey/types.hpp" | ||
| namespace Gigamonkey::Bitcoin::P2P { | ||
| class AssociationID { |
Contributor
There was a problem hiding this comment.
Is there any reason for this to be an abstract type? Would we ever use any other kind of association ID?
GaeaKat
force-pushed
the
feature/peer2peer
branch
from
bf5ba07 to
7d9a20c
Compare
DanielKrawisz
force-pushed
the
master
branch
10 times, most recently
from
5184307 to
89d3f7a
Compare
DanielKrawisz
force-pushed
the
master
branch
from
3104623 to
d6e8b01
Compare
DanielKrawisz
force-pushed
the
master
branch
from
1641a23 to
80e2323
Compare
DanielKrawisz
force-pushed
the
master
branch
2 times, most recently
from
ae4b677 to
694fa43
Compare
DanielKrawisz
force-pushed
the
master
branch
4 times, most recently
from
64823d7 to
7d7c4f3
Compare
DanielKrawisz
force-pushed
the
master
branch
4 times, most recently
from
a52ff4f to
eb37ede
Compare
DanielKrawisz
force-pushed
the
master
branch
from
0f3fdfc to
e676f74
Compare
DanielKrawisz
force-pushed
the
master
branch
2 times, most recently
from
f2db7c7 to
2e131a1
Compare
DanielKrawisz
force-pushed
the
master
branch
from
a623f1b to
3554faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.