Open
Conversation
Manvityagi
requested changes
Jun 20, 2021
Member
Manvityagi
left a comment
Manvityagi
left a comment
There was a problem hiding this comment.
You have changed it only for the mobile view.
Also, on several view-ports, the blue line under the text is misplaced, that needs to be fixed too.
Member
|
The new tagline is shorter than the original one, so the blue line under the text is misplacing on several viewports, after changing the text. The PR should also address that issue and make sure that the blue line is always just under the word "Skill", See the ideal behavior in the original website by resizing the view-ports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I solve your Issue. Please check and Accept pull request.