Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
- Coverage 94.50% 94.49% -0.01%
==========================================
Files 200 201 +1
Lines 12767 12780 +13
==========================================
+ Hits 12065 12077 +12
- Misses 702 703 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The rust-based http-client introduced breaking changes to users that were relying on custom CAs. This commit introduces a custom agent that provides better support in these cases and maintains backwards compatibility with the client used in ggshield's python logic.
6d7a
force-pushed
the
6d7a/setup-truststore-for-forked-children
branch
from
September 28, 2026 06:59
48ef81a to
4e92269
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #1508
1.54.0 introduced two TLS issues that caused backwards incompatibility:
ureqclient differed in its configuration from our python client, which caused issues for some users in self-hosted environmentsWhat has been done
PR check list
skip-changeloglabel has been added to the PR.