-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-217) Template based release notes creation #283
(GH-217) Template based release notes creation #283
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #283 +/- ##
===========================================
+ Coverage 77.34% 78.36% +1.01%
===========================================
Files 54 54
Lines 1130 1137 +7
Branches 135 131 -4
===========================================
+ Hits 874 891 +17
+ Misses 235 225 -10
Partials 21 21
Continue to review full report at Codecov.
|
@gep13 @AdmiringWorm In the first step I added the Scriban library to have a template based release notes creation. If you agree with the changes, I would add in next step a A question is how should it be handeled when the
|
@akordowski I would suggest that if the user has asked to use a template, and that template file doesn't exist, then this should be treated as an error, and we should throw an exception, indicating that the required file couldn't be found. |
@akordowski if the template file is empty, then this to me is also an exception, and we should throw an error. |
@gep13 I made the changes as discussed. The PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor change...
@akordowski this is looking really good! One thing though, would it be possible for you to squash some of your commits down into a set of logical commits? We don't really need additional commits like "Fixed Unit Test". Thanks |
@gep13 I made the changes as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I believe the build failure here, after the rebase, isn't related, it is an issue with codecov. |
@akordowski thanks again for getting this done, really appreciate it! |
Description
This PR addresses #217.
Checklist: