Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
selfdocumentingcode authored and arturcic committed Sep 10, 2024
1 parent 697c973 commit 5efec84
Show file tree
Hide file tree
Showing 7 changed files with 59 additions and 8 deletions.
4 changes: 4 additions & 0 deletions gitreleasemanager/addasset/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ inputs:
description: The directory on which GitReleaseManager should be executed. Defaults to current directory
required: false
default: ''
logFilePath:
description: Path to where log file should be created. Defaults to logging to console.
required: false
default: ''
4 changes: 4 additions & 0 deletions gitreleasemanager/close/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ inputs:
description: The directory on which GitReleaseManager should be executed. Defaults to current directory
required: false
default: ''
logFilePath:
description: Path to where log file should be created. Defaults to logging to console.
required: false
default: ''
4 changes: 4 additions & 0 deletions gitreleasemanager/discard/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ inputs:
description: The directory on which GitReleaseManager should be executed. Defaults to current directory
required: false
default: ''
logFilePath:
description: Path to where log file should be created. Defaults to logging to console.
required: false
default: ''
4 changes: 4 additions & 0 deletions gitreleasemanager/open/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ inputs:
description: The directory on which GitReleaseManager should be executed. Defaults to current directory
required: false
default: ''
logFilePath:
description: Path to where log file should be created. Defaults to logging to console.
required: false
default: ''
5 changes: 5 additions & 0 deletions gitreleasemanager/publish/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,8 @@ inputs:
description: The directory on which GitReleaseManager should be executed. Defaults to current directory
required: false
default: ''
logFilePath:
description: Path to where log file should be created. Defaults to logging to console.
required: false
default: ''

15 changes: 10 additions & 5 deletions src/__tests__/tools/gitreleasemanager/settings.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ describe('GitReleaseManager settings', () => {
owner: 'owner',
token: 'token',
targetDirectory: 'path',
milestone: 'milestone'
milestone: 'milestone',
logFilePath: './output.log'
}

const buildAgent = {
Expand All @@ -66,7 +67,8 @@ describe('GitReleaseManager settings', () => {
owner: 'owner',
token: 'token',
targetDirectory: 'path',
milestone: 'milestone'
milestone: 'milestone',
logFilePath: './output.log'
}

const buildAgent = {
Expand All @@ -86,7 +88,8 @@ describe('GitReleaseManager settings', () => {
owner: 'owner',
token: 'token',
targetDirectory: 'path',
milestone: 'milestone'
milestone: 'milestone',
logFilePath: './output.log'
}

const buildAgent = {
Expand All @@ -106,7 +109,8 @@ describe('GitReleaseManager settings', () => {
owner: 'owner',
token: 'token',
targetDirectory: 'path',
milestone: 'milestone'
milestone: 'milestone',
logFilePath: './output.log'
}

const buildAgent = {
Expand All @@ -127,7 +131,8 @@ describe('GitReleaseManager settings', () => {
token: 'token',
targetDirectory: 'path',
milestone: 'milestone',
assets: ['asset']
assets: ['asset'],
logFilePath: './output.log'
}

const buildAgent = {
Expand Down
31 changes: 28 additions & 3 deletions src/__tests__/tools/gitreleasemanager/tool.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ describe('GitReleaseManagerTool', () => {
owner: 'owner',
repository: 'repo',
token: 'token',
targetDirectory: 'targetDirectory'
targetDirectory: 'targetDirectory',
logFilePath: './logFilePath'
} as CommonSettings

beforeEach(() => {
Expand All @@ -162,7 +163,18 @@ describe('GitReleaseManagerTool', () => {
...commonSettings
} as CommonSettings)

expect(args).toEqual(['--owner', 'owner', '--repository', 'repo', '--token', 'token', '--targetDirectory', 'targetDirectory'])
expect(args).toEqual([
'--owner',
'owner',
'--repository',
'repo',
'--token',
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath'
])
})

it('should throw error for non-existing target path', async () => {
Expand Down Expand Up @@ -192,7 +204,8 @@ describe('GitReleaseManagerTool', () => {
milestone: 'milestone',
inputFileName: 'inputFileName',
isPreRelease: true,
assets: ['asset1', 'asset2']
assets: ['asset1', 'asset2'],
logFilePath: './createLogFilePath'
} as CreateSettings)

expect(args).toEqual([
Expand All @@ -205,6 +218,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./createLogFilePath',
'--milestone',
'milestone',
'--name',
Expand Down Expand Up @@ -237,6 +252,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath',
'--milestone',
'milestone'
])
Expand All @@ -260,6 +277,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath',
'--milestone',
'milestone'
])
Expand All @@ -283,6 +302,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath',
'--milestone',
'milestone'
])
Expand All @@ -306,6 +327,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath',
'--tagName',
'milestone'
])
Expand All @@ -330,6 +353,8 @@ describe('GitReleaseManagerTool', () => {
'token',
'--targetDirectory',
'targetDirectory',
'--logFilePath',
'./logFilePath',
'--tagName',
'milestone',
'--assets',
Expand Down

0 comments on commit 5efec84

Please sign in to comment.