build(deps): bump third_party/ncnn/upstream from f6e1c0c to dda2e28#403
build(deps): bump third_party/ncnn/upstream from f6e1c0c to dda2e28#403dependabot[bot] wants to merge 2 commits into
f6e1c0c to dda2e28#403Conversation
Bumps [third_party/ncnn/upstream](https://github.com/GizClaw/ncnn) from `f6e1c0c` to `dda2e28`. - [Commits](GizClaw/ncnn@f6e1c0c...dda2e28) --- updated-dependencies: - dependency-name: third_party/ncnn/upstream dependency-version: dda2e28bae2a084760361197d87f06e685604e52 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1bc9919f30
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit f6e1c0cd495494e5fdac27fc58fbeb59e8a965a9 | |||
| Subproject commit dda2e28bae2a084760361197d87f06e685604e52 | |||
There was a problem hiding this comment.
With this change only the source submodule moves forward, but supported linux/darwin cgo builds still include and link the committed artifacts under third_party/ncnn/prebuilt/<platform> (for example pkgs/agent/ncnn/cgo_linux_amd64.go:6-7), and those artifacts/manifests remain unchanged at the old ncnn_version 20260113. Since tools/ncnn/README.md:4 names this submodule as the source of truth and tools/ncnn/README.md:18-20,56 documents packaging those builds for pkg/agent/ncnn, the bump will not actually ship the new NCNN code or fixes to users unless the four prebuilts are rebuilt, packaged, and verified in the same change.
Useful? React with 👍 / 👎.
|
The review is correct. This PR only moves the NCNN source gitlink, but supported linux/darwin cgo builds still include and link the committed prebuilt artifacts from the old NCNN build. Closing this source-only Dependabot PR; NCNN should be updated in a follow-up change that rebuilds, packages, and verifies all supported prebuilts with the submodule bump. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
1 participant
Bumps third_party/ncnn/upstream from
f6e1c0ctodda2e28.Commits
dda2e28skip fp16a gpu test (#6820)f74639dgemm block quantization infrastructure for llm decoder style (#6814)13b6d53fix naive mha out-of-bound read (#6812)bd58421pnnx reshape improve compatibility with old ncnn (#6806)81e8cbfpnnx ci update torch 2.12 (#6796)b10a832pnnx ncnn legalize global pooling layout (#6795)127b414reshape support batch to/from dim (#6784)244f30cBump actions/cache from 5 to 6 (#6786)ea028c5Bump actions/checkout from 6 to 7 (#6785)f6f734fvulkan int8 kernels (#6751)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)