Upstream changes#54
Merged
Merged
Conversation
RBE builds require specifying all input sources. This adds a filegroup for the bindings so they can be specified in the modules which require them.
These came in with Rust version 1.89.0
Isn't used, remove.
Contributor
Author
|
I added the linter fixes after setting the pull request title. Those aren't downstream. |
Contributor
Author
|
These are ready for merge. |
Owner
|
Sorry, I was swamped with other stuff and this fell off my radar. 🙇 No issue with the changes; merged them all, thanks! |
Owner
|
While at it, I noticed that there are a bunch of new |
Contributor
Author
|
No worries! I figured it had just slipped and a simple ping would bring it to you attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindgen bump is necessary for integration into the Android tree. Bindgen there is already v0.72.1 .
The other two are downstream patches that are added to sync up downstream/upstream. Not sure if anybody else is using them. They were already broken by my addition of paste. I hadn't realized at the time but the Android.bp file needed to also include the dependency.