Add built-in UAPI headers, and feature to force using UAPI headers.#59
Open
showier-drastic wants to merge 1 commit into
Open
Add built-in UAPI headers, and feature to force using UAPI headers.#59showier-drastic wants to merge 1 commit into
showier-drastic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds code within
build.rsto check for the current kernel header version, and if kernel version is less than 6.8 (building will definitely fail for kernel < 6.8 in the current state, asv4l2_ctrl_av1_frameis missing), use the built-in UAPI headers. A feature flagbuiltin-uapi-headeris added to force using builtin headers. IfV4L2R_VIDEODEV2_H_PATHis specified, the built-in UAPI headers won't be used, so existing users won't be affected.A script is added (
lib/update-uapi-headers.sh) to sync the UAPI headers from the current host system.DEFAULT_VIDEODEV2_H_PATHis removed, because clang will contain/usr/includewithin the default include path, and with this you can successfully find#include <linux/videodev2.h>, so there is no need forDEFAULT_VIDEODEV2_H_PATHin the default case. Moreover, the default value is wrong, because this will result in/usr/include/linux/linux/videodev2.hanyways. So it should cause no harm to remove this.This closes #58.