Added gizmos to help align interactable joints #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malcolmnixon
force-pushed
the
interactable_gizmos
branch
from
c29448b to
5164a96
Compare
This PR resolves request GodotVR#584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that: - New origin nodes have been introduced where the ranges are visualized - Testing showed Y-Axis inversion on the slider and joystick
Malcolmnixon
force-pushed
the
interactable_gizmos
branch
from
5164a96 to
d9c2595
Compare
BastiaanOlij
approved these changes
Dec 11, 2023
Member
BastiaanOlij
left a comment
BastiaanOlij
left a comment
There was a problem hiding this comment.
lgtm, can merge when we've got 4.3.1 out.
Member
|
@Malcolmnixon to revisit this, should rebase and see if any changes are required in order to merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves request #584 by adding gizmos to align interactable hinges, sliders, and joysticks. This does cause minor breakage in that:
Demonstration Video
Gizmos.mp4
Slider Gizmo
Hinge Gizmo
Joystick Gizmo