Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore for asset to prevent checking in temp dlls #106

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

BastiaanOlij
Copy link
Member

@BastiaanOlij BastiaanOlij commented Mar 11, 2024

Small change, this PR adds a .gitignore file into the asset folder that is distributed within the asset zip file.

This has no effect on this repo itself as we already exclude DLLs, though those should be included in projects using this asset.
However the Godot editor will now make copies of the dll files before opening them to allow live reloading. For projects using our asset these dlls show up as items to be checked in. This gitignore prevents that.

note 1 ideally this should be in the users root .gitignore file and may in the near future be added in Godot upstream.
note 2 I don't know if similar behaviour happens on Linux or Mac, if so we may want to add additional entries.

@BastiaanOlij BastiaanOlij added the enhancement New feature or request label Mar 11, 2024
@BastiaanOlij BastiaanOlij self-assigned this Mar 11, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

These temporary copies are only made on Windows - it's not needed on other platforms.

@m4gr3d m4gr3d merged commit d312a8c into GodotVR:master Mar 11, 2024
7 checks passed
@m4gr3d m4gr3d added this to the 3.0.0 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants