-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add support for the Android XR OpenXR vendor #238
base: master
Are you sure you want to change the base?
Conversation
plugin/build.gradle
Outdated
android { | ||
dimension "vendor" | ||
ndk { | ||
//noinspection ChromeOsAbiSupport | ||
abiFilters 'arm64-v8a', 'x86_64' | ||
} | ||
externalNativeBuild { | ||
cmake { | ||
arguments "-DFLAVOR=android" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need another AAR built? We've never used the FLAVOR
define in the C++ anywhere - could we just use the Khronos AAR for Android too?
(The same goes for MagicLeap - I think we could reuse the Khronos AAR for that as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess it's because the Java code is different.
Well, after PR #227 is merged, this won't be as big of a deal because with that one we do only one C++ build, and then each of the Java builds just reuses the artifacts of that :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the new flavor is primarily for the difference in the java code and the manifest. The C++ code and configuration is the same as the others.
189e37d
to
0607bdd
Compare
0607bdd
to
982fc9d
Compare
982fc9d
to
aeeb41b
Compare
aeeb41b
to
0226ae9
Compare
0226ae9
to
2b00fa0
Compare
This PR adds support for the Android XR OpenXR vendor, which will provide the ability to run Godot XR apps on Android XR devices via the vendor plugin.
Android
vendor.