-
Notifications
You must be signed in to change notification settings - Fork 41
Add Camera-Stream Crosshairs #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 78.36% 78.03% -0.34%
==========================================
Files 86 86
Lines 8594 8749 +155
==========================================
+ Hits 6735 6827 +92
- Misses 1859 1922 +63 ☔ View full report in Codecov by Sentry. |
I am not going to lie, I am not quite sure how to test custom painters. From what I have seen online, the main way to do it is to have an image that has the specific overlay from the CustomPainter already done, and to then compare it pixel by pixel during the test. |
Resolves #226.
Allows users to create a crosshair with an x, y, thickness, height, width, and color.
Todo: