Skip to content

Add Camera-Stream Crosshairs #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

EmeraldWither
Copy link
Contributor

@EmeraldWither EmeraldWither commented Apr 29, 2025

Resolves #226.

Allows users to create a crosshair with an x, y, thickness, height, width, and color.

image

Todo:

  • add relevant options in widget properties window to allow user to customize
  • save options
  • double check all tests and write new ones
  • double check any possible performance impacts

@github-actions github-actions bot added the GUI Changes to Elastic's UI label Apr 29, 2025
@EmeraldWither EmeraldWither marked this pull request as draft April 29, 2025 03:22
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 69 lines in your changes missing coverage. Please review.

Project coverage is 78.03%. Comparing base (1032e94) to head (f3b8d8f).

Files with missing lines Patch % Lines
lib/widgets/mjpeg.dart 0.00% 47 Missing ⚠️
.../widgets/nt_widgets/multi_topic/camera_stream.dart 80.70% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   78.36%   78.03%   -0.34%     
==========================================
  Files          86       86              
  Lines        8594     8749     +155     
==========================================
+ Hits         6735     6827      +92     
- Misses       1859     1922      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EmeraldWither
Copy link
Contributor Author

I am not going to lie, I am not quite sure how to test custom painters. From what I have seen online, the main way to do it is to have an image that has the specific overlay from the CustomPainter already done, and to then compare it pixel by pixel during the test.

@EmeraldWither EmeraldWither marked this pull request as ready for review May 6, 2025 00:32
@EmeraldWither
Copy link
Contributor Author

Updated settings page
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Changes to Elastic's UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add crosshair on CameraPublisher
1 participant