Skip to content

Conversation

@YanVictorSN
Copy link
Contributor

@YanVictorSN YanVictorSN commented Feb 4, 2025

Description

  • Fix the shape of the container (with 2 cicular ends)
  • Include the wrapping issue (.eth going past the container). Should be addressed with truncation similar to the wallet address.
  • The G$ location should go first (before numbers, like G$ 11111)

Before:
antes

Now:
now

Close #272

@L03TJ3

@L03TJ3 L03TJ3 merged commit 90cd665 into GoodDollar:master Feb 5, 2025
1 of 2 checks passed
@sirpy
Copy link
Contributor

sirpy commented Feb 5, 2025

@YanVictorSN @L03TJ3 why should the ens name be truncated? why doesnt the container expand?

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Feb 5, 2025

@sirpy

  1. we do it for wallet-address
  2. limited amount of space on mobile

@YanVictorSN YanVictorSN deleted the improve-wallet-containers branch February 5, 2025 09:56
@sirpy
Copy link
Contributor

sirpy commented Feb 5, 2025

@sirpy

  1. we do it for wallet-address
  2. limited amount of space on mobile

ok. so it should be limited to mobile design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG, GoodCollective] Improve wallet containers to follow the design

3 participants