-
Notifications
You must be signed in to change notification settings - Fork 20
Feat: support more wallets using reown #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @YanVictorSN - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a consistent naming convention for platform-specific components (e.g.,
ConnectWalletMenu.native.tsxandConnectWalletMenu.web.tsx). - It looks like you're conditionally rendering different app entrypoints based on the platform, consider using a single entrypoint and platform-specific modules instead.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
| Complex Provider Nesting ▹ view | ||
| Unconfigured Global QueryClient Instance ▹ view | ✅ | |
| Missing Real-time Allowance Updates ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| packages/app/src/AppWrapper.ts | ✅ |
| packages/app/src/config.ts | ✅ |
| packages/app/src/components/Header/ConnectWalletMenuWrapper.ts | ✅ |
| packages/app/src/utils/superFluidInstance.tsx | ✅ |
| packages/app/src/components/Header/ConnectWalletMenu.web.tsx | ✅ |
| packages/app/src/hooks/useIsStewardVerified.ts | ✅ |
| packages/app/src/pages/WalletProfilePage.tsx | ✅ |
| packages/app/web/main.tsx | ✅ |
| packages/app/src/hooks/useGetTokenBalance.ts | ✅ |
| packages/app/src/hooks/useEthers.ts | ✅ |
| packages/app/src/hooks/useContractCalls/useDeleteFlow.ts | ✅ |
| packages/app/src/components/StewardsList/StewardsListItem.tsx | ✅ |
| packages/app/src/hooks/useContractCalls/useSupportSingleBatch.ts | ✅ |
| packages/app/src/hooks/useContractCalls/useSupportSingleTransferAndCall.ts | ✅ |
| packages/app/src/hooks/useContractCalls/useSupportFlow.ts | ✅ |
| packages/app/src/hooks/useContractCalls/useSupportSingleWithSwap.ts | ✅ |
| packages/app/src/hooks/useContractCalls/useSupportFlowWithSwap.ts | ✅ |
| packages/app/src/components/TransactionList/SupportTransactionListItem.tsx | ✅ |
| packages/app/src/hooks/useSwapRoute.tsx | ✅ |
| packages/app/src/hooks/useApproveSwapTokenCallback.ts | ✅ |
| packages/app/src/components/Header/Header.tsx | ✅ |
| packages/app/src/App.web.tsx | ✅ |
| packages/app/src/App.tsx | ✅ |
| packages/app/src/components/Header/ConnectWalletMenu.tsx | ✅ |
| packages/app/src/components/Header/ConnectedAccountDisplay.tsx | ✅ |
| packages/app/src/components/DonateComponent.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
sirpy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are still multiple un addressed comments from the previous review
- The connectwalletmenu.native should be adapted to reown native
- There are multiple code repetition between app and app.native do we really require two different files for native and web? if so extract mutual code
sirpy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- merge latest changes from master
- you need to commit yarn.lock changes
@sirpy What do you mean by point 1? Can you explain, please? 2- I committed the package.json. Do you need the yarn.lock file too? |
|
b4698f0 to
f443ebd
Compare
|
@YanVictorSN please fix the typescript error in useNetFlow |
|
@sirpy done |
|
@YanVictorSN good job. check out ubi.gd/GoodBuilders |
|
@sirpy Thank you! I'll check that. |
Description
Closes #227
Description by Korbit AI
What change is being made?
Integrate support for additional wallets using the Reown AppKit within the app.
Why are these changes being made?
These changes enable the app to support a wider range of cryptocurrency wallets via the Reown library, improving compatibility and user experience. The refactor simplifies wallet connection logic by leveraging the Reown AppKit and Wagmi Adapter, while streamlining existing code to enhance maintainability.