mento reserve upgrade #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mento reserve upgrade
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
sirpy
force-pushed
the
reserve-hack-fix
branch
from
f420762 to
494ba11
Compare
Tru2thisNu
approved these changes
Jan 12, 2025
MehrdadBadriGol
approved these changes
Feb 2, 2025
MehrdadBadriGol
approved these changes
Feb 2, 2025
MehrdadBadriGol
approved these changes
Mar 5, 2025
sirpy
added a commit
that referenced
this pull request
Mar 31, 2025
* fix: make sure GOOD rewards are updated on change * fix: limit amount of G$ to sell for fees * fix: dont count on fundmanager and exchange helper for funds transfer * fix: dont allow untrusted staking contracts * fix: dont allow transfer of hacked funds * add: hack fix upgrade script * add: test for reward update fix * add: celo distribution helper * add: basic upgrade script * Revert "fix: dont count on fundmanager and exchange helper for funds transfer" This reverts commit deeec59. * Revert "fix: dont allow transfer of hacked funds" This reverts commit a88a438. * revert: initial reserve deposit * fix: reset so other test file dont break * fix: e2e testing issue * add: todo * add: mento upgrade simulation and contract * add: mint ubi calculation fixes and guardian proposal approval * fix: dont count on fundmanager and exchange helper for funds transfer * add: only trust reservesupply for ubi minting * fix: new var storage location * add: eth reserve restore upgrade * add: audit fixes * add: fix tests * fix: celodisthelper sell gd * fix: celodist helper tests * fix: failing test * fix: coverage * add: use transferfrom to prevent dai lock. upgrade fuse governance * add: remove mento upgrade into separate PR * add: removed outdated todo * fix: code review use constant for repeating addresses * fix: remove redundant require * add: allow to restore reserve in batches * mento reserve upgrade (#274) * wip: metno upgrade * fix: make sure to unpause reserve only after funds restoration * fix: exit contribution from mento audit * add: working mento upgrade for dev * fix: restore deleted * add: celo dev env deployment + simulation * add: adapt to mento after audit * fix: comments * add: final upgrade script for celo reserve * fix: allow stakers to withdraw from staking contracts if G$ rewards pending * fix: dont try to mint reward if reserve is paused * fix: dont fail distribution if cant buy native tokens * fix: use global supply to determine initial price * add: adapt script to work with us deploying mento reserve * add: full broker interface * add: dont mint GOOD post hack on ethereum * add: deployed production + safe sdk upgrade * fix: disable coverage * fix: superfluid missing contract * add: checksonly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Disable certain job steps in the CI pipeline by introducing new if conditions set to false and add new interfaces including
IMentoReserve,IBancorExchangeProvider,IGoodDollarExpansionController,IGoodDollarExchangeProvider, andITradingLimitsinMentoInterfaces.solto the codebase. Add a newCeloDistributionHelpercontract and its test helper along with upgrading theGoodMarketMaker,GoodFundManager, and modifying configurations inhardhat.config.ts. Introduce new deployment scripts and update package dependencies along with deployment configuration.Why are these changes being made?
These changes aim to disable parts of the CI pipeline temporarily for testing or debugging purposes without removing the code, and to enhance contract functionality by adding significant improvements such as upgrading the protocol to incorporate new Mento components. This facilitates integration with Celo and improves functionality through new distribution and reserve handling mechanisms while simplifying and updating scripts and deployment configurations to better align with the current requirements of the project.