Xdc deploy #282
Merged
Xdc deploy #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sirpy, your pull request is larger than the review limit of 150000 diff characters
sirpy
commented
Sep 30, 2025
| accounts: [deployerPrivateKey] | ||
| }, | ||
| "development-xdc": { | ||
| ...xdc |
Collaborator
There was a problem hiding this comment.
Because script uses network.name to save contract address in deployment.json
Comment on lines
+85
to
+86
| amount0Min: amount0.mul(8).div(10), | ||
| amount1Min: amount1.mul(8).div(10), |
Collaborator
There was a problem hiding this comment.
I set it to 80% of amountDesired, which effectively serves as a price sanity check.
Xdc deploy
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
L03TJ3
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
XDC support and small updates
Description by Korbit AI
What change is being made?
Add and wire up XDC deployment support including new interfaces, a distribution helper contract, updated UBIScheme initialization, and deployment/test scripts to accommodate multi-chain distribution and governance flows.
Why are these changes being made?
Enable XDC network deployment and multi-chain distribution capabilities, with configurable minActiveUsers and updated test/deployment plumbing to reflect the new constructor parameters and bridge flows.