-
Notifications
You must be signed in to change notification settings - Fork 20
add references to relient dependencies #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues... but I did find this shark.
(`.
\ `.
) `._..---._
\`. __...---` o )
\ `._,--' , ___,'
) ,-._ \ ) _,-'
/,' ``--.._____\/--''Check out our docs on how you can make Korbit work best for you and your team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- There’s a typo in the new section—
relientshould bereliant(or use “dependent on”) for clarity. - Consider renaming the heading to something like “Dependent Packages or Apps” to make the purpose clearer.
- It might be helpful to alphabetize or categorize the list of repositories to keep it maintainable as it grows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s a typo in the new section—`relient` should be `reliant` (or use “dependent on”) for clarity.
- Consider renaming the heading to something like “Dependent Packages or Apps” to make the purpose clearer.
- It might be helpful to alphabetize or categorize the list of repositories to keep it maintainable as it grows.
## Individual Comments
### Comment 1
<location> `README.md:38` </location>
<code_context>
+
+## Packages or Apps dependencies
+
+The following packages or app repositories are relient on the @gooddollar/goodprotocol package and should be notified to review potential needed updates:
+
+- [GoodWeb3-Mono](https://github.com/GoodDollar/GoodWeb3-Mono)
</code_context>
<issue_to_address>
**issue (typo):** Typo: 'relient' should be 'reliant'.
Update the sentence to use the correct spelling: 'reliant'.
```suggestion
The following packages or app repositories are reliant on the @gooddollar/goodprotocol package and should be notified to review potential needed updates:
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| ## Packages or Apps dependencies | ||
|
|
||
| The following packages or app repositories are relient on the @gooddollar/goodprotocol package and should be notified to review potential needed updates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Typo: 'relient' should be 'reliant'.
Update the sentence to use the correct spelling: 'reliant'.
| The following packages or app repositories are relient on the @gooddollar/goodprotocol package and should be notified to review potential needed updates: | |
| The following packages or app repositories are reliant on the @gooddollar/goodprotocol package and should be notified to review potential needed updates: |
Description
Add reference links to the related GoodDollar packages/sdk's
Description by Korbit AI
What change is being made?
Add a new "Packages or Apps dependencies" section to README.md that lists repositories reliant on @gooddollar/goodprotocol and should be notified to review potential updates.
Why are these changes being made?
To inform dependent projects that rely on the package about potential needed updates, helping coordinate ecosystem changes.