add: xdc support #603

sirpy · 2025-08-17T18:11:14Z

Description

Added support for dev env xdc
requires matching branch from goodweb3-mono

To test

icons
claim switch to next chain
rpcs
gas cost

Description by Korbit AI

What change is being made?

Add support for the XDC network across the codebase, including dependencies, logo assets, supported chain configuration, network modals, and explorer URL handling.

Why are these changes being made?

These changes enable the application to support the XDC network, which is crucial for broadening the scope of decentralized technology access across different blockchain networks. The updates allow the system to recognize XDC as a native currency, handle network-specific connections, display logos, and manage transactions through XDC's block explorer. Limitations include network-specific features not being optimized yet, requiring future refinement of network-specific functionalities.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

cloudflare-workers-and-pages · 2025-08-17T18:12:22Z

Deploying goodprotocolui with Cloudflare Pages

Latest commit:	`66ab226`
Status:	✅ Deploy successful!
Preview URL:	https://07af597a.goodprotocolui.pages.dev
Branch Preview URL:	https://xdc-upgrade.goodprotocolui.pages.dev

View logs

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Unsafe Network Name Processing ▹ view
	Static XDC Gas Price ▹ view	✅ Fix detected
	Exposed API Key in Frontend Code ▹ view

Files scanned

File Path	Reviewed
src/utils/env.ts	✅
src/constants/multicall/index.ts	✅
src/components/BlockNativeOnboard/index.tsx	✅
src/constants/networks.ts	✅
src/pages/gd/Claim/Claim.tsx	✅
src/components/CurrencyLogo/index.tsx	✅
src/pages/gd/Claim/ClaimBalance.tsx	✅
src/hooks/useWeb3.tsx	✅
src/connectors/index.ts	✅
src/components/NetworkModal/index.tsx	✅
src/components/SideBar.tsx	✅
src/constants/index.ts	✅
src/utils/index.ts	✅
src/components/Faq/copies.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

src/hooks/useWeb3.tsx

+            if (chainId === (50 as ChainId) && method === 'eth_sendTransaction') {
+                params[0].gasPrice = BigNumber.from(12.5e9).toHexString()
+            }


korbit-ai · 2025-08-17T18:21:00Z

src/pages/gd/Claim/Claim.tsx

    MAINNET: process.env.REACT_APP_GOODID_MAINNET_EXPLORER ?? '',
+    XDC:
+        process.env.REACT_APP_GOODID_XDC_EXPLORER ??
+        `https://api.etherscan.io/v2/api?chainid=50&apikey=${process.env.REACT_APP_ETHERSCAN_KEY}&`,


Exposed API Key in Frontend Code

Tell me more

What is the issue?

API key is being exposed in client-side code where it could be extracted by end users.

Why this matters

Client-side exposure of API keys allows unauthorized usage, potential abuse, and billing implications. API requests should be proxied through a backend service.

Suggested change ∙ Feature Preview

Move API calls to a backend service and create an authenticated endpoint that proxies requests to Etherscan:

// Frontend const goodIdExplorerUrls = { CELO: process.env.REACT_APP_GOODID_CELO_EXPLORER ?? 'your-backend-api/explorer/celo', XDC: process.env.REACT_APP_GOODID_XDC_EXPLORER ?? 'your-backend-api/explorer/xdc' }

Provide feedback to improve future suggestions

_{💬 Looking for more details? Reply to this comment to chat with Korbit.}

korbit-ai · 2025-08-17T18:21:00Z

src/utils/env.ts

+    if (network.includes('-')) {
+        const baseNetwork = network.split('-')[0]
        return baseNetwork
    }


Unsafe Network Name Processing

Tell me more

What is the issue?

The code assumes all network names with a hyphen follow the same format and only takes the first part, which could lead to incorrect environment determination for networks with different naming patterns.

Why this matters

If new networks are added with different naming patterns containing hyphens (e.g., 'test-xdc-network'), the function will return 'test' instead of the intended environment, potentially causing the application to run in the wrong environment.

Suggested change ∙ Feature Preview

Create a whitelist of known network prefixes or implement a more robust network name parsing logic. Example:

if (network.includes('-')) { // Whitelist approach const knownNetworks = ['development', 'staging', 'production']; const prefix = network.split('-')[0]; return knownNetworks.includes(prefix) ? prefix : defaultValue; }

Provide feedback to improve future suggestions

_{💬 Looking for more details? Reply to this comment to chat with Korbit.}

- fix switch-chain on claim-alt - on xdc, always go to old claim flow (no goodid)

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents

Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `src/utils/index.ts:251` </location>
<code_context>
-    },
-    fuse: (chainName = '', data: string, type: 'transaction' | 'token' | 'address' | 'block') => {
-        const prefix = 'https://explorer.fuse.io/'
+    celo: (chainName = '', data: string, type: 'transaction' | 'token' | 'address' | 'block') => {
+        const prefix = 'https://celoscan.io/'
         switch (type) {
</code_context>

<issue_to_address>
The builder for XDC uses a trailing slash in the prefix; check for double slashes in generated URLs.

Consider removing the trailing slash from the prefix to prevent double slashes in the generated URLs.
</issue_to_address>

<suggested_fix>
<<<<<<< SEARCH
        const prefix = 'https://celoscan.io/'
=======
        const prefix = 'https://celoscan.io'
>>>>>>> REPLACE

</suggested_fix>

### Comment 2
<location> `src/pages/gd/Claim/index.tsx:27` </location>
<code_context>
     if (payload === undefined || isGoodIdEnabled === undefined) return <Spinner variant="page-loader" size="lg" />

-    return isGoodIdEnabled && !isMiniPay ? <NewClaim /> : <OldClaim />
+    return isGoodIdEnabled && !isMiniPay && chainId !== 50 ? <NewClaim /> : <OldClaim />
 }

</code_context>

<issue_to_address>
The claim page disables NewClaim for chainId 50 (XDC); clarify rationale.

If XDC is intentionally excluded, please add a comment or TODO explaining the reason for future reference.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

sourcery-ai · 2025-09-05T04:34:10Z

src/utils/index.ts

-    fuse: (chainName = '', data: string, type: 'transaction' | 'token' | 'address' | 'block') => {
-        const prefix = 'https://explorer.fuse.io/'
+    celo: (chainName = '', data: string, type: 'transaction' | 'token' | 'address' | 'block') => {
+        const prefix = 'https://celoscan.io/'


suggestion: The builder for XDC uses a trailing slash in the prefix; check for double slashes in generated URLs.

Consider removing the trailing slash from the prefix to prevent double slashes in the generated URLs.

Suggested change

const prefix = 'https://celoscan.io/'

const prefix = 'https://celoscan.io'

sourcery-ai · 2025-09-05T04:34:11Z

src/pages/gd/Claim/index.tsx

    if (payload === undefined || isGoodIdEnabled === undefined) return <Spinner variant="page-loader" size="lg" />

-    return isGoodIdEnabled && !isMiniPay ? <NewClaim /> : <OldClaim />
+    return isGoodIdEnabled && !isMiniPay && chainId !== 50 ? <NewClaim /> : <OldClaim />


question: The claim page disables NewClaim for chainId 50 (XDC); clarify rationale.

If XDC is intentionally excluded, please add a comment or TODO explaining the reason for future reference.

src/utils/env.ts

korbit-ai

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Static XDC Gas Price ▹ view	✅ Fix detected
	Incorrect XDC Fallback RPC URL ▹ view
	Incorrect Environment Detection for Hyphenated Network Names ▹ view
	Inverted Claim Availability Logic ▹ view
	Hardcoded Chain-specific Gas Prices ▹ view	✅ Fix detected

Files scanned

File Path	Reviewed
src/utils/env.ts	✅
src/pages/gd/Claim/index.tsx	✅
src/components/Web3SupportedNetworks/index.tsx	✅
src/constants/multicall/index.ts	✅
src/components/BlockNativeOnboard/index.tsx	✅
src/constants/networks.ts	✅
src/pages/gd/Claim/Claim.tsx	✅
src/components/CurrencyLogo/index.tsx	✅
src/components/Savings/SavingsCard/index.tsx	✅
src/pages/gd/Stake/Savings/index.tsx	✅
src/pages/gd/Claim/ClaimBalance.tsx	✅
src/hooks/useWeb3.tsx	✅
src/connectors/index.ts	✅
src/components/NetworkModal/index.tsx	✅
src/components/SideBar.tsx	✅
src/constants/index.ts	✅
src/utils/index.ts	✅
src/components/Faq/copies.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

src/connectors/index.ts

src/utils/env.ts

src/hooks/useWeb3.tsx

+            if (chainId === (50 as ChainId) && method === 'eth_sendTransaction') {
+                params[0].gasPrice = BigNumber.from(12.5e9).toHexString()
+            }


src/hooks/useWeb3.tsx

            if (!isMiniPay && chainId === (42220 as ChainId) && method === 'eth_sendTransaction') {
                params[0].gasPrice = BigNumber.from(25.001e9).toHexString()
            }

            if (chainId === (122 as ChainId) && method === 'eth_sendTransaction') {
                params[0].gasPrice = BigNumber.from(11e9).toHexString()
            }
+
+            if (chainId === (50 as ChainId) && method === 'eth_sendTransaction') {
+                params[0].gasPrice = BigNumber.from(12.5e9).toHexString()
+            }


korbit-ai · 2025-09-05T04:35:16Z

src/pages/gd/Claim/ClaimBalance.tsx

+        if (!claimedCelo?.isZero() && Number(chainId) !== SupportedChains.CELO) {
+            return setClaimNext(SupportedChains.CELO)
+        }
+        if (!claimedXdc?.isZero() && Number(chainId) !== SupportedChains.XDC) {
+            return setClaimNext(SupportedChains.XDC)
+        }
+        if (!claimedFuse?.isZero() && Number(chainId) !== SupportedChains.FUSE) {
+            return setClaimNext(SupportedChains.FUSE)
+        } else setClaimNext(undefined)


Inverted Claim Availability Logic

Tell me more

What is the issue?

The logic for determining the next chain to claim on is incorrect. It sets the next chain when a claim is NOT zero (meaning already claimed) instead of when it IS zero (available to claim).

Why this matters

Users will be directed to chains where they've already claimed instead of chains where claims are available, preventing them from accessing their available claims.

Suggested change ∙ Feature Preview

Invert the logic to check for zero claims:

if (claimedCelo?.isZero() && Number(chainId) !== SupportedChains.CELO) { return setClaimNext(SupportedChains.CELO) } if (claimedXdc?.isZero() && Number(chainId) !== SupportedChains.XDC) { return setClaimNext(SupportedChains.XDC) } if (claimedFuse?.isZero() && Number(chainId) !== SupportedChains.FUSE) { return setClaimNext(SupportedChains.FUSE) } else setClaimNext(undefined)

Provide feedback to improve future suggestions

_{💬 Looking for more details? Reply to this comment to chat with Korbit.}

Wrong, isZero here means there is no available claim.

I apologize for the confusion. You are correct - isZero() indicates no available claim, so the current logic is appropriate. Please disregard my previous suggestion.

add: xdc support

178b635

sirpy had a problem deploying to preview August 17, 2025 18:11 — with GitHub Actions Failure

sirpy self-assigned this Aug 17, 2025

korbit-ai bot had a problem deploying to preview August 17, 2025 18:11 Failure

sirpy assigned L03TJ3 Aug 17, 2025

korbit-ai bot had a problem deploying to preview August 17, 2025 18:11 Failure

sirpy removed their assignment Aug 17, 2025

korbit-ai bot reviewed Aug 17, 2025

View reviewed changes

- fix portfolio page on dev, exclude xdc from savings

992a86c

- fix switch-chain on claim-alt - on xdc, always go to old claim flow (no goodid)

L03TJ3 had a problem deploying to preview September 3, 2025 18:10 — with GitHub Actions Failure

chore: bump gd-sdks packages

66ab226

L03TJ3 deployed to preview September 4, 2025 14:30 — with GitHub Actions View deployment

L03TJ3 deployed to preview September 4, 2025 14:31 — with GitHub Actions View deployment

L03TJ3 marked this pull request as ready for review September 5, 2025 04:32

L03TJ3 deployed to preview September 5, 2025 04:32 — with GitHub Actions View deployment

korbit-ai bot deployed to preview September 5, 2025 04:32 View deployment

sourcery-ai bot reviewed Sep 5, 2025

View reviewed changes

korbit-ai bot reviewed Sep 5, 2025

View reviewed changes

L03TJ3 added 2 commits September 5, 2025 12:05

simplify gas override

0106f72

chore: lingui

6c73e56

L03TJ3 deployed to preview September 5, 2025 05:08 — with GitHub Actions View deployment

L03TJ3 merged commit 29a64e2 into master Sep 5, 2025
3 checks passed

L03TJ3 deleted the xdc-upgrade branch September 5, 2025 05:09

	const prefix = 'https://celoscan.io/'
	const prefix = 'https://celoscan.io'

add: xdc support #603

add: xdc support #603

Uh oh!

Conversation

sirpy commented Aug 17, 2025 • edited by korbit-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

To test

Description by Korbit AI

What change is being made?

Why are these changes being made?

Uh oh!

cloudflare-workers-and-pages bot commented Aug 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying goodprotocolui with Cloudflare Pages

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

This comment was marked as resolved.

Uh oh!

korbit-ai bot Aug 17, 2025

Choose a reason for hiding this comment

Exposed API Key in Frontend Code

What is the issue?

Why this matters

Suggested change ∙ Feature Preview

Provide feedback to improve future suggestions

Uh oh!

korbit-ai bot Aug 17, 2025

Choose a reason for hiding this comment

Unsafe Network Name Processing

What is the issue?

Why this matters

Suggested change ∙ Feature Preview

Provide feedback to improve future suggestions

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

sourcery-ai bot Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

korbit-ai bot Sep 5, 2025

Choose a reason for hiding this comment

Inverted Claim Availability Logic

What is the issue?

Why this matters

Suggested change ∙ Feature Preview

Provide feedback to improve future suggestions

Uh oh!

L03TJ3 Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

korbit-ai bot Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

sirpy commented Aug 17, 2025 •

edited by korbit-ai bot

Loading

cloudflare-workers-and-pages bot commented Aug 17, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

korbit-ai bot left a comment •

edited

Loading