Minipay wagmi connector #615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ority (GoodWallet, Valora), Google socials, MiniPay labeling; migrate connect flows to AppKit
… refactor, useConnectionInfo, restore XDC, clean TODOs, fix keys and ESLint warnings
…eError, add wallet QA checklist
…Chat, AccountDetails, Web3ReactManager, Web3Network)
Resolved conflicts and API compatibility: - AppBar.tsx: Integrated with new AppKit hooks - NetworkModal/index.tsx: Combined AppKit with activeNetworksByFeature - ClaimBalance.tsx: Updated to use new SDK API - OldClaim.tsx: Kept AppKit connection handling - WalletBalance/index.tsx: Fixed chainId type conversion - All locale files: Accepted master's updated translations - yarn.lock: Regenerated with updated dependencies Note: New SDK version - useG no longer accepts chainId parameter
…into feat-appkit
…ge, and bug fixes
…into feat-appkit
…into feat-appkit
…into feat-appkit
…into feat-appkit
- Only add MiniPay connector to array when MiniPay is actually detected - Prevents 'connector not found' errors when MiniPay is not available - Fallback to injected() connector for other wallets
# Conflicts: # src/language/locales/af/catalog.po # src/language/locales/ar/catalog.po # src/language/locales/ca/catalog.po # src/language/locales/cs/catalog.po # src/language/locales/da/catalog.po # src/language/locales/de/catalog.po # src/language/locales/el/catalog.po # src/language/locales/en/catalog.po # src/language/locales/es-419/catalog.po # src/language/locales/es/catalog.po # src/language/locales/fi/catalog.po # src/language/locales/fr/catalog.po # src/language/locales/he/catalog.po # src/language/locales/hi/catalog.po # src/language/locales/hu/catalog.po # src/language/locales/it/catalog.po # src/language/locales/ja/catalog.po # src/language/locales/ko/catalog.po # src/language/locales/nl/catalog.po # src/language/locales/no/catalog.po # src/language/locales/pl/catalog.po # src/language/locales/pt-BR/catalog.po # src/language/locales/pt/catalog.po # src/language/locales/ro/catalog.po # src/language/locales/ru/catalog.po # src/language/locales/sr/catalog.po # src/language/locales/sv/catalog.po # src/language/locales/tr/catalog.po # src/language/locales/uk/catalog.po # src/language/locales/vi/catalog.po # src/language/locales/zh-CN/catalog.po # src/language/locales/zh-TW/catalog.po # src/language/locales/zh/catalog.po # src/pages/gd/Swap/SwapCore/mentoReserve.tsx
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a MiniPay wagmi connector package and improves the user experience with connection status feedback. The implementation follows the official MiniPay documentation patterns to ensure proper integration.
Summary of implementation
miniPayConnectorwith standardinjected()connector (listed first in connectors array) as per MiniPay documentation requirementsconnect({ connector: connectors[0] })useAccount()from wagmi: Replaced custom hooks with standard wagmiuseAccount()hook for address retrievalMotivation and Context
The previous implementation used a custom connector which caused type compatibility issues and connection failures. The "unknown account #0" error indicated that the wallet wasn't connecting properly. This PR restructures the implementation to follow the official MiniPay documentation exactly:
injected()connector (listed first)connectors[0]useAccount()from wagmi for address retrievalDependencies
wagmi@reown/appkitHow Has This Been Tested?
yarn tsc --noEmit)yarn build)waitForMiniPayProvider()utilityNote: Full integration testing requires running the app in MiniPay browser/standalone app (Android/iOS device with Developer Mode enabled).
Checklist:
@sirpy @Lewis - Please review.