Feature: Implement KMS Wallet #510
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added KMS wallet support to handle Ethereum transactions securely using AWS Key Management Service. - Updated configuration to allow KMS key IDs and region settings. - Refactored AdminWallet and Web3Wallet to support KMS-based transaction signing. - Introduced KMSWallet class to encapsulate KMS operations. - Added tests for KMS transaction submission and wallet functionality.
- Updated KMSWallet and Web3Wallet to store and retrieve wallet addresses in a case-insensitive manner. - Removed unnecessary console log from KMSWallet during transaction signing. - Adjusted tests to ensure KMS wallet address normalization is correctly handled.
…just Jest configuration
…ated package versions in package.json and package-lock.json
sirpy
requested changes
Dec 23, 2025
|
|
||
| const sendTx = this.mainnetWeb3.eth.sendSignedTransaction(signedTx) | ||
|
|
||
| return new Promise((res, rej) => { |
| const region = this.getRegion(address) | ||
|
|
||
| try { | ||
| if (transaction.rpcUrl != undefined && transaction.rpcUrl.includes('localhost')) { |
Contributor
There was a problem hiding this comment.
write a comment why you do this
| this.networkId = networkId | ||
| this.numberOfAdminWalletAccounts = conf.privateKey ? 1 : conf.numberOfAdminWalletAccounts | ||
| // Determine number of accounts based on configuration | ||
| let kmsKeyIds = null |
Contributor
There was a problem hiding this comment.
can we just read existing kmskeys from aws? maybe read keys by tags?
Comment on lines
+118
to
+125
| if (conf.kmsKeyIds) { | ||
| kmsKeyIds = conf.kmsKeyIds | ||
| .split(',') | ||
| .map(k => k.trim()) | ||
| .filter(k => k) | ||
| } | ||
| if (kmsKeyIds && kmsKeyIds.length > 0) { | ||
| this.numberOfAdminWalletAccounts = kmsKeyIds.length |
Contributor
There was a problem hiding this comment.
should be moved to initialize and keys should be fetched by group/tag
| this.wallets[normalizedAddress] = { address, kmsKeyId, isKMS: true } | ||
| } | ||
|
|
||
| getKMSKeyIds() { |
Contributor
There was a problem hiding this comment.
should be fetched from aws by group/tag
|
|
||
| getKMSKeyIds() { | ||
| // Support comma-separated list of keys | ||
| if (this.conf.kmsKeyIds) { |
Contributor
There was a problem hiding this comment.
instead of kmskeyids use kmsKeysTag
| addresses.forEach(address => { | ||
| const keyId = this.kmsWallet.getKeyId(address) | ||
| this.addKMSWallet(address, keyId) | ||
| // Add KMS addresses to filledAddresses (they don't need admin verification) |
Contributor
There was a problem hiding this comment.
not true, need same checks as in mnemonic.
dont duplicate code
Contributor
There was a problem hiding this comment.
make sure balance check are run for these addresses also
| * Send transaction using KMS signing | ||
| * @private | ||
| */ | ||
| async sendTransactionWithKMS( |
Contributor
There was a problem hiding this comment.
deduplicate code like in AdminWallet you have just one sendTransaction method
| env: 'PRIVATE_KEY', | ||
| default: undefined | ||
| }, | ||
| kmsKeyIds: { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the KMS wallet, which signs transactions using keys stored in AWS KMS.
The
kms-ethereum-signingdependency is the modularized PoC project I previously built.About # (link your issue here)
How Has This Been Tested?
The KMS wallet is tested in
adminWalletKMS.test.ts.Checklist: