Fixes workbox dependencies - #1667
Conversation
|
Thanks鈥攖his is something that I caught when doing a dependency update sweep in preparation for our v4 release: https://github.com/GoogleChrome/workbox/pull/1658/files#diff-d9674ca55441128e3145e9552ce61a71R31 I believe that we were getting by because My personal preference would be to just defer to that upcoming change in v4 unless this is something that is actively causing a failure for you with the current v3 release. |
|
I noticed it while working on react/create-react-app#5136, which adds support for Plug'n'Play to create-react-app. Since package boundaries are enforced under this environment, it throws an error: |
|
Gotcha鈥擮kay, we can merge this in for a |
|
Thanks鈥擨 was just going to ask about the |
|
Perfect, thanks! |
|
Thanks again! |

cc @jeffposnick @philipwalton (didn't open an issue since both the problem and fix are relatively straightforwards)
Description of what's changed/fixed.
The
workbox-webpack-pluginis trying to access thebabel-runtimepackage (because it gets transformed usingbabel-plugin-transform-runtime), which isn't declared in its dependencies. As a result package managers offer no guarantee as to which version will be provided, or even ifbabel-runtimewill be installed at all.This diff simply adds the dependency that's missing, based on what I found in the
package-lock.jsonat the root of the repository.