Initial spark 3.5 catalog #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
isha97
reviewed
Jan 28, 2025
...-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryTableCatalog.java
Outdated
Show resolved
Hide resolved
...-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryTableCatalog.java
Outdated
Show resolved
Hide resolved
...-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryTableCatalog.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public Table alterTable(Identifier identifier, TableChange... tableChanges) |
There was a problem hiding this comment.
Is this something that we want to support later?
...query-lib/src/main/java/com/google/cloud/spark/bigquery/v2/Spark34BigQueryTableProvider.java
Show resolved
Hide resolved
...-3.5-bigquery-lib/src/main/java/com/google/cloud/spark/bigquery/v2/BigQueryTableCatalog.java
Outdated
Show resolved
Hide resolved
|
The write integration tests are failing in the build. PTAL. |
| @Override | ||
| public Table loadTable(Identifier identifier) throws NoSuchTableException { | ||
| logger.debug("loading table [{}])", format(identifier)); | ||
| return identifierToTableMapping.computeIfAbsent( |
There was a problem hiding this comment.
This is a cache with no expiry. Seems problematic.
Is this safe to use across scans?
There was a problem hiding this comment.
Thanks, replaced with a cache. It should be safe, unless the table is deleted and re-created with a different schema in the same process
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Can you please update the Changes.md as well? |
davidrabinowitz
force-pushed
the
catalog
branch
from
f0d67cd to
82de568
Compare
isha97
approved these changes
Feb 6, 2025
davidrabinowitz
merged commit 2cea89c
into
GoogleCloudDataproc:master
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.