-
Notifications
You must be signed in to change notification settings - Fork 265
feat: Add GKE Inference Gateway blueprints for a4 and a4x #4908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Add GKE Inference Gateway blueprints for a4 and a4x #4908
Conversation
Summary of ChangesHello @SinaChavoshi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the GKE Inference Gateway offerings by introducing dedicated blueprints for A4 and A4X machine types. These additions provide users with ready-to-deploy configurations that streamline the setup of GKE clusters optimized for high-performance AI inference, replicating the successful pattern established by the existing A3 blueprint. The new blueprints include comprehensive network, compute, and workload management settings, along with updated documentation to guide users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new blueprints for GKE Inference Gateway on a4 and a4x machine types. The changes are well-structured and the new a4x blueprint is clean and focused. However, the a4 blueprint appears to include some unnecessary components and overly permissive IAM roles, likely from being copied from a training-focused blueprint. My review includes suggestions to align the a4 blueprint with the leaner a4x version, enhancing security and maintainability.
This PR introduces new example blueprints to facilitate the deployment of GKE clusters optimized for the Inference Gateway on a4 and a4x machine types.
These changes replicate the existing pattern from the
gke-a3-highgpu-inference-gateway.yamlblueprint.Key Changes:
examples/gke-a4/gke-a4-inference-gateway.yamland a corresponding deployment file. This blueprint configures a GKE cluster with the necessaryREGIONAL_MANAGED_PROXYsubnet and enables theenable_inference_gatewayflag.examples/gke-a4x/gke-a4x-inference-gateway.yamland a corresponding deployment file, following the same pattern as the a4 blueprint.examples/README.mdto include descriptions and links for the newgke-a4-inference-gateway.yamlandgke-a4x-inference-gateway.yamlblueprints.These additions make it easier for users to get started with Inference Gateway on the latest A4 and A4X hardware.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.