Skip to content

Conversation

@SinaChavoshi
Copy link
Member

This PR introduces new example blueprints to facilitate the deployment of GKE clusters optimized for the Inference Gateway on a4 and a4x machine types.

These changes replicate the existing pattern from the gke-a3-highgpu-inference-gateway.yaml blueprint.

Key Changes:

  • New Blueprint for a4: Added examples/gke-a4/gke-a4-inference-gateway.yaml and a corresponding deployment file. This blueprint configures a GKE cluster with the necessary REGIONAL_MANAGED_PROXY subnet and enables the enable_inference_gateway flag.
  • New Blueprint for a4x: Added examples/gke-a4x/gke-a4x-inference-gateway.yaml and a corresponding deployment file, following the same pattern as the a4 blueprint.
  • Documentation: Updated examples/README.md to include descriptions and links for the new gke-a4-inference-gateway.yaml and gke-a4x-inference-gateway.yaml blueprints.

These additions make it easier for users to get started with Inference Gateway on the latest A4 and A4X hardware.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SinaChavoshi SinaChavoshi requested review from a team and samskillman as code owners December 1, 2025 23:34
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SinaChavoshi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the GKE Inference Gateway offerings by introducing dedicated blueprints for A4 and A4X machine types. These additions provide users with ready-to-deploy configurations that streamline the setup of GKE clusters optimized for high-performance AI inference, replicating the successful pattern established by the existing A3 blueprint. The new blueprints include comprehensive network, compute, and workload management settings, along with updated documentation to guide users.

Highlights

  • GKE A4 Inference Gateway Blueprint: Introduced a new blueprint (examples/gke-a4/gke-a4-inference-gateway.yaml) and its deployment file, configuring a GKE cluster with REGIONAL_MANAGED_PROXY subnet and enabling the enable_inference_gateway flag for A4 machine types.
  • GKE A4X Inference Gateway Blueprint: Added a new blueprint (examples/gke-a4x/gke-a4x-inference-gateway.yaml) and its deployment file, mirroring the A4 blueprint but optimized for A4X machine types, including specific configurations for nvidia-gb200 accelerators and ARM64 architecture.
  • Documentation Update: The examples/README.md file has been updated to include descriptions and links for the newly added GKE A4 and A4X Inference Gateway blueprints, improving discoverability for users.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new blueprints for GKE Inference Gateway on a4 and a4x machine types. The changes are well-structured and the new a4x blueprint is clean and focused. However, the a4 blueprint appears to include some unnecessary components and overly permissive IAM roles, likely from being copied from a training-focused blueprint. My review includes suggestions to align the a4 blueprint with the leaner a4x version, enhancing security and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant