Address review comments for PR #4834 #5037
Conversation
…d validation This commit updates the `placement_policy` variable in `modules/compute/vm-instance/variables.tf` to use a strict `object` type with optional fields, including the new `gpu_topology`. It also updates the validation block to correctly handle `null` values while preventing empty objects. The `main.tf` and `README.md` files are updated to reflect these changes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
closing this request as i was experimenting jules. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
Addressed review comments from PR #4834.
placement_policytype fromanytoobject(...).gpu_topologytoplacement_policy.placement_policyvalidation to ensure at least one non-null field is provided if the object is not null.google_compute_resource_policyto includegpu_topology.placement_policy.PR created automatically by Jules for task 580983354514681396 started by @LAVEEN