Support Document Models with dicts in LLMRater#295
Merged
IsmailMehdi merged 4 commits intoGoogleCloudPlatform:mainfrom Mar 31, 2026
Merged
Support Document Models with dicts in LLMRater#295IsmailMehdi merged 4 commits intoGoogleCloudPlatform:mainfrom
IsmailMehdi merged 4 commits intoGoogleCloudPlatform:mainfrom
Conversation
added 2 commits
March 30, 2026 07:51
Fix util.make_hashable to recursively unwrap nested objects in lists, preventing TypeErrors when caching. Cleaned up duplication in SetMatcher and adopted collections.Counter for robust multiset matching.
Added tests for standard flat dictionaries, limits enforcement, and empty datasets.
added 2 commits
March 30, 2026 08:20
Collaborator
|
/gcbrun |
IsmailMehdi
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeError in llmrater.py that occurred when processing document models (nested lists/dicts).
Changes: