Skip to content

Update OWNERS - #211

Merged
google-oss-prow[bot] merged 2 commits into
mainfrom
bradhoekstra-patch-1
Apr 14, 2026
Merged

Update OWNERS#211
google-oss-prow[bot] merged 2 commits into
mainfrom
bradhoekstra-patch-1

Conversation

@bradhoekstra

Copy link
Copy Markdown
Collaborator

Add GKE team members as reviewers

Add GKE team members as reviewers
@bradhoekstra
bradhoekstra requested a review from a team as a code owner April 13, 2026 18:28
@google-oss-prow
google-oss-prow Bot requested review from erain and juli4n April 13, 2026 18:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OWNERS file by adding a new reviewers section. The review feedback suggests removing redundant entries for individuals who are already listed as approvers and recommends sorting the list alphabetically to improve maintainability.

Comment thread OWNERS Outdated
Comment on lines +10 to +15
- bradhoekstra
- GinnyJI
- stalhaali
- toshiowang
- jayantid
- dshnayder

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The reviewers list contains redundant entries and is not alphabetically sorted. bradhoekstra and GinnyJI are already listed as approvers (lines 2 and 6). In standard OWNERS file implementations (such as those used in Kubernetes-related projects), approvers are implicitly reviewers, so they do not need to be duplicated in this section. Additionally, sorting the list alphabetically improves maintainability and helps prevent future duplicates.

- dshnayder
- jayantid
- stalhaali
- toshiowang

@google-oss-prow google-oss-prow Bot added size/S and removed size/XS labels Apr 13, 2026
@bradhoekstra

Copy link
Copy Markdown
Collaborator Author

/verify-owners

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradhoekstra, erain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bradhoekstra

Copy link
Copy Markdown
Collaborator Author

/verify-owners

@google-oss-prow
google-oss-prow Bot merged commit f1c638a into main Apr 14, 2026
25 checks passed
@bradhoekstra
bradhoekstra deleted the bradhoekstra-patch-1 branch April 29, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants