Skip to content

chore(secretmanager): Added samples for delayed destroy #10136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

durgesh-ninave-crest
Copy link
Contributor

Description

Added samples for kms_key field in regional parameter using Parameter manager SDK

Sample List (global & regional):

  1. Create Secret With Delayed Destroy
  2. Disable Secret Delayed Destroy
  3. Update Secret With Delayed Destroy

Added required Tests for the same.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 23, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a set of new Java samples for Google Cloud Secret Manager, focusing on the 'delayed destroy' functionality for secret versions. It provides examples for creating, updating, and disabling this feature for both global and regional Secret Manager instances, along with robust integration tests to ensure proper operation.

Highlights

  • New Secret Management Samples: I've added three new Java samples for Google Cloud Secret Manager: CreateSecretWithDelayedDestroy, DisableSecretDelayedDestroy, and UpdateSecretWithDelayedDestroy. These samples demonstrate how to manage secrets with a 'delayed destroy' feature, allowing for a specified time before a secret version is permanently destroyed.
  • Regional API Support: Corresponding regional samples (CreateRegionalSecretWithDelayedDestroy, DisableRegionalSecretDelayedDestroy, UpdateRegionalSecretWithDelayedDestroy) have been introduced. These samples illustrate how to perform the same delayed destroy operations using regional Secret Manager endpoints, providing flexibility for geographically distributed applications.
  • Comprehensive Testing: New integration tests have been included in SnippetsIT.java and regionalsamples/SnippetsIT.java to validate the functionality of all the new delayed destroy samples, ensuring their correctness and reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new samples for creating, updating, and disabling delayed destruction of secrets in Secret Manager, for both global and regional secrets. The changes include the sample code and corresponding integration tests. There is a critical bug in one of the new regional samples due to swapped method arguments. I've also suggested improvements for robustness by changing the type of versionDestroyTtl from Integer to long across all new samples to avoid potential NullPointerExceptions.

Copy link

@YashSaraf11 YashSaraf11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

@durgesh-ninave-crest
Copy link
Contributor Author

Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.

I've updated the assertion to reflect the intended functionality of the sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants