-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(secretmanager): Added samples for delayed destroy #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(secretmanager): Added samples for delayed destroy #10136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @durgesh-ninave-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a set of new Java samples for Google Cloud Secret Manager, focusing on the 'delayed destroy' functionality for secret versions. It provides examples for creating, updating, and disabling this feature for both global and regional Secret Manager instances, along with robust integration tests to ensure proper operation.
Highlights
- New Secret Management Samples: I've added three new Java samples for Google Cloud Secret Manager:
CreateSecretWithDelayedDestroy
,DisableSecretDelayedDestroy
, andUpdateSecretWithDelayedDestroy
. These samples demonstrate how to manage secrets with a 'delayed destroy' feature, allowing for a specified time before a secret version is permanently destroyed. - Regional API Support: Corresponding regional samples (
CreateRegionalSecretWithDelayedDestroy
,DisableRegionalSecretDelayedDestroy
,UpdateRegionalSecretWithDelayedDestroy
) have been introduced. These samples illustrate how to perform the same delayed destroy operations using regional Secret Manager endpoints, providing flexibility for geographically distributed applications. - Comprehensive Testing: New integration tests have been included in
SnippetsIT.java
andregionalsamples/SnippetsIT.java
to validate the functionality of all the new delayed destroy samples, ensuring their correctness and reliability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new samples for creating, updating, and disabling delayed destruction of secrets in Secret Manager, for both global and regional secrets. The changes include the sample code and corresponding integration tests. There is a critical bug in one of the new regional samples due to swapped method arguments. I've also suggested improvements for robustness by changing the type of versionDestroyTtl
from Integer
to long
across all new samples to avoid potential NullPointerException
s.
...ager/src/main/java/secretmanager/regionalsamples/CreateRegionalSecretWithDelayedDestroy.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/CreateSecretWithDelayedDestroy.java
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/UpdateSecretWithDelayedDestroy.java
Show resolved
Hide resolved
...ager/src/main/java/secretmanager/regionalsamples/CreateRegionalSecretWithDelayedDestroy.java
Show resolved
Hide resolved
...ager/src/main/java/secretmanager/regionalsamples/UpdateRegionalSecretWithDelayedDestroy.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please assert in the test scenarios that the delayed destory was disabled or updated. I do not see any assert statements on those tests for the operation verification.
I've updated the assertion to reflect the intended functionality of the sample. |
Description
Added samples for kms_key field in regional parameter using Parameter manager SDK
Sample List (global & regional):
Added required Tests for the same.
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only