Make skills template-only#272
Merged
ptone merged 2 commits intoMay 31, 2026
Merged
Conversation
Skills are harness-agnostic instruction snippets that belong exclusively in templates. Remove the provisioning code that copied skills from the harness-config base layer — no shipped harness-config provides a skills directory, so this drops no existing functionality. Update the documentation and tests to reflect that skills come only from templates. Closes #91
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the harness-config skill-copy step from agent provisioning, making templates the sole source of skills. The provisioning logic in pkg/agent/provision.go has been updated, and the documentation and tests have been adjusted accordingly to verify that harness-config skills are no longer copied. There are no review comments, so no feedback is provided.
krohnjw
pushed a commit
to ParkWhiz/scion
that referenced
this pull request
Jun 3, 2026
* Make skills template-only, remove harness-config skill-copy step Skills are harness-agnostic instruction snippets that belong exclusively in templates. Remove the provisioning code that copied skills from the harness-config base layer — no shipped harness-config provides a skills directory, so this drops no existing functionality. Update the documentation and tests to reflect that skills come only from templates. Closes GoogleCloudPlatform#91 * Add project log for skills template-only cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/agent/provision.go— skills are harness-agnostic and belong exclusively in templatesdocs-site/src/content/docs/advanced-local/templates.mdto document skills as template-onlyTestProvisionAgent_SkillsDirOverlay→TestProvisionAgent_SkillsAreTemplateOnlyto verify harness-config skills are no longer copiedNo shipped harness-config contains a
skillsdirectory, so this is a no-op for existing users.Closes ptone#91
Test plan
TestProvisionAgent_CopiesSkillsDirpasses (template skills still work)TestProvisionAgent_SkillsAreTemplateOnlypasses (harness-config skills are ignored)go test ./pkg/agent/passesgo vet ./pkg/agent/clean