Skip to content

fix(#3869): Updated Dropdown borders to be the same as Input - #170

Merged
ArakTaiRoth merged 1 commit into
mainfrom
dustin/3869
Aug 4, 2026
Merged

fix(#3869): Updated Dropdown borders to be the same as Input#170
ArakTaiRoth merged 1 commit into
mainfrom
dustin/3869

Conversation

@ArakTaiRoth

Copy link
Copy Markdown
Collaborator

dropdown-border-error, dropdown-border-hover, and dropdown-border-error-hover have all been changed to use input.borderWidth.hover to make it the same as the Input component.

@twjeffery twjeffery left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArakTaiRoth I checked these against the Figma input styles. The hover change is right, but the error changes go the wrong way.

Figma has the input borders at 1px default, 1.5px hover, 2px focus, 2px error.

The dropdown was wrong at 2px on hover, so 1.5px is the correct fix. But error and error hover were already right at 2px, and this moves them off spec. Let's keep the hover change and leave error and error hover as they were.

The issue has it backwards on that row. It uses the text input as the reference, but the text input's error border is the one that's off. It should be 2px, not 1.5px.

Two other things this turned up:

  1. Text input and text area both have their error border at 1.5px, so they need the opposite fix from this one.
  2. Dropdown multiselect has the same 2px hover as the dropdown, so it needs the same change this PR is making.

@ArakTaiRoth
ArakTaiRoth force-pushed the dustin/3869 branch 2 times, most recently from e3a4704 to a57b8d6 Compare July 29, 2026 20:43
@ArakTaiRoth

Copy link
Copy Markdown
Collaborator Author

@ArakTaiRoth I checked these against the Figma input styles. The hover change is right, but the error changes go the wrong way.

Figma has the input borders at 1px default, 1.5px hover, 2px focus, 2px error.

The dropdown was wrong at 2px on hover, so 1.5px is the correct fix. But error and error hover were already right at 2px, and this moves them off spec. Let's keep the hover change and leave error and error hover as they were.

The issue has it backwards on that row. It uses the text input as the reference, but the text input's error border is the one that's off. It should be 2px, not 1.5px.

Two other things this turned up:

  1. Text input and text area both have their error border at 1.5px, so they need the opposite fix from this one.
  2. Dropdown multiselect has the same 2px hover as the dropdown, so it needs the same change this PR is making.

@twjeffery I believe I fixed all the issues you raised

@ArakTaiRoth
ArakTaiRoth requested a review from twjeffery July 29, 2026 20:45
@ArakTaiRoth
ArakTaiRoth merged commit 6bbe42a into main Aug 4, 2026
4 checks passed
@ArakTaiRoth
ArakTaiRoth deleted the dustin/3869 branch August 4, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown: hover and error border widths are inconsistent with text input and text area

2 participants