Skip to content

Conversation

@DavidHarvey
Copy link
Contributor

Addresses #6651

@artf
Copy link
Member

artf commented Nov 19, 2025

Hey @DavidHarvey, thanks for the PR, but I think this would break the textable functionality.
By default, we avoid dropping anything inside text components and it's false by default. The textable is intentionally breaks that rule on text components and that's why we have that logic here.

@DavidHarvey
Copy link
Contributor Author

@artf Do you have a suggestion for exposing the ability to prevent dropping textable components onto text in that case? If we're intentionally ignoring the droppable value of the destination, then should we have another configuration value?

@artf
Copy link
Member

artf commented Nov 19, 2025

@DavidHarvey I think, based on the current logic, you can extend the text component with droppable as a function:

droppable: () => false,

@DavidHarvey
Copy link
Contributor Author

DavidHarvey commented Nov 19, 2025

@artf That works as a workaround. However, are we ok with telling users that:

droppable: false

has different functionality than

droppable: () => false

in certain circumstances? This strikes me as a possible point of confusion.

@artf
Copy link
Member

artf commented Nov 20, 2025

Yeah agree, it's a bit confusing right now but textable prop is a bit "special" I'd say.

I'd avoid changing the default Text behavior but maybe we can introduce a new prop to Text component that allows to skip textable components inside (eg. avoidTextable: false as default), wdyt?

FYI I'll close the ticket and the PR at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants