Skip to content

fix: backport workflow #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2025
Merged

fix: backport workflow #1872

merged 3 commits into from
Jun 26, 2025

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Jun 26, 2025

What's Changed in this PR

Describe the change in this PR

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in sidebars.ts matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

@sunng87
Copy link
Member Author

sunng87 commented Jun 26, 2025

backport! 0.14

Copy link
Contributor

ℹ️ Backport command executed for version 0.14, but no changes were detected.

This might mean:

  • No changes needed to be backported
  • The backport command didn't produce any modifications

@sunng87
Copy link
Member Author

sunng87 commented Jun 26, 2025

backport! 0.14

Copy link
Contributor

ℹ️ Backport command executed for version 0.14, but no changes were detected.

This might mean:

  • No changes needed to be backported
  • The backport command didn't produce any modifications

@sunng87 sunng87 changed the title test: backport fix: backport workflow Jun 26, 2025
This reverts commit 7ebcec2.
@sunng87 sunng87 marked this pull request as ready for review June 26, 2025 03:42
Copy link

cloudflare-workers-and-pages bot commented Jun 26, 2025

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ecb3029
Status: ✅  Deploy successful!
Preview URL: https://688f8f7d.greptime-docs.pages.dev
Branch Preview URL: https://test-backport.greptime-docs.pages.dev

View logs

@sunng87 sunng87 requested review from nicecui, waynexia and Copilot June 26, 2025 03:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the backport workflow to ensure it runs as expected during CI/CD.

  • Updated the Node.js version from 18 to 22.
  • Modified the npm run backport command to correctly forward arguments.
Comments suppressed due to low confidence (2)

.github/workflows/backport.yml:58

  • Ensure that upgrading to Node.js version 22 is compatible with all workflow dependencies and caching mechanisms.
          node-version: '22'

.github/workflows/backport.yml:66

  • Verify that adding the '--' ensures the npm script 'backport' correctly receives all intended arguments without breaking existing functionality.
          npm run backport -- --version ${{ steps.extract_version.outputs.version }} --since main

@sunng87 sunng87 merged commit aaa9bac into main Jun 26, 2025
4 checks passed
@sunng87 sunng87 deleted the test/backport branch June 26, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants