Skip to content

Shift Complete Item Functionality to Task Dropdown Menu #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjfwalker wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Shift Complete Item Functionality to Task Dropdown Menu #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bbe689f
Watch for hover event on each item bullet
tjfwalker Dec 21, 2016
23b2138
Create the item-dropdown
tjfwalker Dec 21, 2016
b6dcd38
Reveal item Menu On Bullet Hover
tjfwalker Dec 21, 2016
bbb63d4
Pacify the great Jrob
tjfwalker Dec 21, 2016
1a3f47f
Correct Mistaken Pug Syntax
tjfwalker Dec 21, 2016
ef72f00
Added whitespace in task dropdown event listeners
tjfwalker Dec 22, 2016
4a76bef
Target Item Accosiated with Menu Clicked From
tjfwalker Dec 22, 2016
90e2ca6
Shift Item Completion Functionality
tjfwalker Dec 22, 2016
10e7059
Fix conflict
tjfwalker Dec 22, 2016
a627b1c
Refactor in Observance of JrobCodeStyle™
tjfwalker Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions public/javascripts/items.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const descriptionEdited = event => {

const completedClicked = event => {
const element = $( event.target )
const id = element.data( 'id' )
const id = element.parent().data( 'id' )
const completed = ! element.data( 'completed' )

fetch( `/items/${id}`, params({ completed: completed } ) )
Expand All @@ -64,9 +64,8 @@ const completedClicked = event => {
} else {
parent.removeClass( 'item__title--completed' )
}
}
)
}
})
}

const getFilterStatus = () => {
const pageURL= decodeURIComponent(window.location.search)
Expand Down Expand Up @@ -133,7 +132,7 @@ $(document).ready( () => {
$( '.item__title > span' ).click( clickToUpdate( 'item__title' ))
$( '.item__edit-description' ).keypress( descriptionEdited )
$( '.item__description > span' ).click( clickToUpdate( 'item__description' ))
$( '.item__toggle' ).click( completedClicked )
$( '.item__menu ul li:first-child' ).click( completedClicked )
Copy link
Contributor

@jrobcodes jrobcodes Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use explicit class

$( '.dropdown__toggle' ).click( dropdownToggle )
$( '.star' ).click( starredToggle )
getFilterStatus()
Expand Down
2 changes: 1 addition & 1 deletion views/items/item-menu.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ul
ul(data-id=entry.id)
li Complete
li Add Note
li Share
Expand Down