User Registration(Closes #55) #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodatall
reviewed
Dec 17, 2016
models/users.js
Outdated
| dragonboard_bar: { type: Boolean, default: true }, | ||
| active: { type: Boolean, default: true } | ||
| }, | ||
| { |
Moniarchy
force-pushed
the
55-user-registration
branch
from
a70a7ad to
f27203c
Compare
jrobcodes
suggested changes
Dec 17, 2016
src/authentication/register.js
Outdated
| } | ||
|
|
||
| return response.status( 201 ).json( tokenInfo( user )) | ||
| response.redirect('http://localhost:3000/dashboard') |
Contributor
There was a problem hiding this comment.
Please add spaces between opening and closing parentheses, and arguments, in a function invocation or control flow expression:
fn(param1, param2) { /* ... */ }
if(expression) { /* ... */ }should be
fn( params1, param2 ) { /* ... */ }
if( expression ) { /* ... */ }
src/authentication/register.js
Outdated
| exports.register = ( request, response, next ) => { | ||
| const { email, password } = request.body | ||
| const { name, email, password, phone_number, newsletter_subscribed, company } | ||
| = request.body |
Contributor
There was a problem hiding this comment.
I do not like this formatting. I would prefer instead:
const {
name, email, password, phone_number, newsletter_subscribed, company
} = request.body| "passport-jwt": "^2.2.1", | ||
| "passport-local": "^1.0.0", | ||
| "pug": "^2.0.0-beta6", | ||
| "rand-token": "^0.3.0", |
Contributor
There was a problem hiding this comment.
Can you tell me about the need for adding this dependency?
Contributor
Author
There was a problem hiding this comment.
Yes, we used it in the UserSchema to generate a random API key for users when a new one is created.
nodatall
force-pushed
the
55-user-registration
branch
from
f27203c to
0aefb04
Compare
jrobcodes
suggested changes
Dec 20, 2016
src/authentication/register.js
Outdated
| } | ||
|
|
||
| return response.status( 201 ).json( tokenInfo( user )) | ||
| response.redirect( 'http://localhost:3000/dashboard' ) |
Contributor
There was a problem hiding this comment.
We should not be hard coding the base URL.
nodatall
force-pushed
the
55-user-registration
branch
from
0aefb04 to
be2bf9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested authentication to make sure users post correctly to the database with required information. updated user schema to reflect that information