-
-
Notifications
You must be signed in to change notification settings - Fork 319
Fix CVE-2025-2308 #5960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christian-wojek
wants to merge
10
commits into
HDFGroup:develop
Choose a base branch
from
christian-wojek:CVE-2025-2308
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix CVE-2025-2308 #5960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
With this change trying to make the distinction between buf_size and buf_len is confusing. Could you rename buf_len to something more descriptive? Perhaps bits_to_fill? Unfortunately this whole file tends to use "len" to mean bits |
Contributor
Author
|
I renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A malformed file can cause the scale-offset filter to have too little input data causing a heap buffer overflow. Additional checks on the maximum buffer length are required during the decompression.
This PR fixes CVE-2025-2308.
Closes #5868.
Important
Fixes CVE-2025-2308 by adding buffer size checks in decompression functions to prevent heap buffer overflow in
H5Zscaleoffset.c.H5Z__scaleoffset_decompress_one_byte()andH5Z__scaleoffset_decompress_one_atomic()to prevent heap buffer overflow.H5Z__scaleoffset_decompress_one_byte()now returnsherr_tand checks if*jexceedsbuf_size.H5Z__scaleoffset_decompress_one_atomic()andH5Z__scaleoffset_decompress()updated to passbuf_sizeand handle buffer overflow.H5Z__filter_scaleoffset()to accommodate new buffer size checks.This description was created by
for 0894715. You can customize this summary. It will automatically update as commits are pushed.