Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distortion check #784

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Fix distortion check #784

merged 2 commits into from
Mar 17, 2025

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Mar 17, 2025

It needed to check an object one level further down...

psavery added 2 commits March 17, 2025 14:32
It needed to check an object one level further down...

Signed-off-by: Patrick Avery <[email protected]>
These are not actually used and should be abstract methods.

Signed-off-by: Patrick Avery <[email protected]>
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (0cc4340) to head (9df499c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
hexrd/instrument/detector.py 0.00% 3 Missing ⚠️
hexrd/fitting/calibration/abstract_grain.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   48.20%   48.35%   +0.14%     
==========================================
  Files         143      143              
  Lines       22935    22860      -75     
==========================================
- Hits        11056    11054       -2     
+ Misses      11879    11806      -73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@psavery psavery merged commit a9e3f70 into master Mar 17, 2025
7 checks passed
@psavery psavery deleted the fix-distortion-check branch March 17, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants