Handle recursion in imageseries get_region() #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes (as is the case for `OmegaImageSeries`), `self._adapter` is itself an imageseries, rather than an imageseries adapter. To handle this recursion, use a forwarding function on the `ImageSeries` base class to forward the call to its adapter (which, if the adapter is itself an imageseries, will then forward the call to its own adapter). This fixes running [this example](https://github.com/HEXRD/examples/blob/master/NIST_ruby/multiruby_dexelas/include/mruby_config_composite_roi.yml). Signed-off-by: Patrick Avery <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 48.35% 48.36%
=======================================
Files 143 143
Lines 22860 22863 +3
=======================================
+ Hits 11054 11057 +3
Misses 11806 11806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChristosT
approved these changes
Mar 27, 2025
|
Yeah, not every example is ran in the tests. Maybe we should add that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (as is the case for
OmegaImageSeries),self._adapteris itself an imageseries, rather than an imageseries adapter.To handle this recursion, use a forwarding function on the
ImageSeriesbase class to forward the call to its adapter (which, if the adapter is itself an imageseries, will then forward the call to its own adapter).This fixes running this example.