Modified pinhole area correction #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commits: [4b6fd05] modify the pinhole effective area correction
This answer is much better and is now the expected answer. Signed-off-by: Patrick Avery <[email protected]>
This is easier to work with when we want to change the `bvec`. Signed-off-by: Patrick Avery <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 48.36% 48.37% +0.01%
==========================================
Files 143 143
Lines 22863 22866 +3
==========================================
+ Hits 11057 11061 +4
+ Misses 11806 11805 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
An error was discovered in the pinhole area correction based on the CeO2 data recorded on TARDIS. An extra
sec(beta)factor was added to the correction published in Rygg et al., Rev. Sci. Instrum. 91, 043902 (2020). This PR makes that change.Another small modification was made to use the existing functionality in the
transformsmodule to compute thebetaangles. This streamlines the function.