Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use buttons in toolbar #1797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Mar 3, 2025

This branch also needs an okay from UDRI folks since this change would affect all user workflows (although hopefully as an improvement for all).
Feedback and remaining changes:

  • Make sure the frame can still be input manually
  • Investigate omega to make sure that the toolbar is not being re-sized/shifting around (Note: There is no fix in this PR but I was unable to reproduce re-sizing/shifting)

@bnmajor bnmajor force-pushed the use-buttons-in-toolbar branch from 50846ba to d60738f Compare March 3, 2025 13:53
@bnmajor bnmajor requested a review from psavery March 3, 2025 13:53
@bnmajor
Copy link
Collaborator Author

bnmajor commented Mar 25, 2025

@psavery There is some additional weirdness that I have noticed while testing this branch. If you click on a point on the slider the value appears to jump around rather that jumping right to that position. In this example it jumps to the last frame and the the value that was clicked on the slider:
Screencast from 03-25-2025 01:23:02 PM.webm
In this example it jumps up in increments of 10 rather than jumping right to the position:
Screencast from 03-25-2025 01:29:29 PM.webm
This does seem to happen in master as well. While I am able to confirm that additional action signals are being sent (causing this behavior) I cannot understand why or if there is a way to correct the behavior.

In the image series toolbar replace the spinbox for multi-frame images with
back/forward buttons and an input text box. Functionality should remain the
same, the goal is simply to provide larger buttons that are easier to use.

Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor force-pushed the use-buttons-in-toolbar branch from 710eebf to ec6bceb Compare March 25, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant