Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New masking features #1815

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

New masking features #1815

wants to merge 13 commits into from

Conversation

bnmajor
Copy link
Collaborator

@bnmajor bnmajor commented Mar 26, 2025

  • Only apply changes to mask presentation on button press, not automatically
  • Remember which image mode a mask was created in
  • Remember which x-ray source was selected when the mask was created (if applicable)
  • Update mask manager dialog to use a tree view instead of a table view
  • Organize masks by view mode + x-ray source in tree
  • Keep backwards compatibility with old mask file versions
  • Automatically hide masks that were not created in the current view mode with the current x-ray source
  • Collapse mask categories that do not match current x-ray source
  • Allow users to skip this automatic mask hiding functionality if desired Skipping for now

Addresses #1791

bnmajor added 5 commits March 26, 2025 16:39
Instead of automatically updating masks as the presentation combo box is
changed, changes are tracked and only applied once "Apply Changes" is clicked.

Signed-off-by: Brianna Major <[email protected]>
Signed-off-by: Brianna Major <[email protected]>
Signed-off-by: Brianna Major <[email protected]>
Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor force-pushed the new-masking-features branch from 22aa1f0 to d4049f6 Compare March 26, 2025 20:45
bnmajor added 6 commits March 27, 2025 16:05
Signed-off-by: Brianna Major <[email protected]>
Rather that a full re-creation of the tree on mask addition/deletion/re-name,
update in place. This preserves the collapsed/expanded state of all parent
items as changes are made.

Signed-off-by: Brianna Major <[email protected]>
If an instrument has multiple x-ray sources then when we are in polar mode we
will automatically hide any masks created for a different x-ray source than the
current selection. Those sections are also automatically collapsed in the
MaskManagerDialog and the section with masks that match the current x-ray
source is expanded.

Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor force-pushed the new-masking-features branch from c12d623 to 7246347 Compare March 27, 2025 20:06
Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor marked this pull request as ready for review March 27, 2025 20:49
Signed-off-by: Brianna Major <[email protected]>
@bnmajor bnmajor requested review from psavery and saransh13 April 2, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant