Optimize string truncation by slicing once at source in workflow_adapter #95
+67
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert free-standing main() coroutine into a proper Click group - Add 'run' sub-command for starting interactive session - Maintain backwards compatibility (invoking without sub-command starts session) - Replace shell-based pycache cleanup with secure shutil.rmtree approach - Add click>=8.0.0 to requirements.txt This enables adding sub-commands like 'deepcode config' or 'deepcode clean' without touching the main logic.
Instead of building 3 giant strings and then slicing each to 1000 chars at display time in cli_app.py, this change truncates once at the source inside workflow_adapter and passes already-truncated snippets. Changes: - Add truncate_for_display() helper function with configurable limit - Add CLI_DISPLAY_TRUNCATE_LIMIT constant (1000) for centralized configuration - Apply truncation in process_input_with_orchestration() before returning results - Simplify display_results() in cli_app.py by removing redundant truncation logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes string handling by truncating once at the source inside
workflow_adapterinstead of building 3 giant strings and then slicing each to 1000 chars at display time incli_app.py.Changes
cli/workflows/cli_workflow_adapter.pyCLI_DISPLAY_TRUNCATE_LIMIT = 1000constant for centralized configurationtruncate_for_display()helper function that truncates strings with an ellipsis suffixprocess_input_with_orchestration()before returninganalysis_result,download_result, andrepo_resultcli/cli_app.py[:1000] + "..."truncation logic from all 3 places indisplay_results()Benefits
cli_app.pyCLI_DISPLAY_TRUNCATE_LIMITconstant makes it easy to adjust the limit in one placePull Request opened by Augment Code with guidance from the PR author