-
Notifications
You must be signed in to change notification settings - Fork 740
fix(locale): unify terminology usage of 'JVM' and 'Java' #3690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5746153
to
fd1e8bc
Compare
a17ee60
to
6c67241
Compare
f0061a1
to
11c1af7
Compare
我比较担心“JVM”这个术语会不会给用户带来困扰。 我感觉对于小白用户来说,“Java 虚拟机”中包含“Java”这个词,一眼就能看出来这个词和 Java 的关系,但 JVM 就不行,所以可能会让很多用户对此感到困惑。 |
如果只为简繁用户保留 “Java 虚拟机”,其他语言保留 “JVM”,如何? |
我觉得可以 |
216f3ee
to
7d5ec97
Compare
- For Chinese, replace the relevant term with 'Java 虚拟机/虛擬機'. - For other languages, replace the relevant term with 'JVM'. - Replace 'JVM' with 'Java' in some cases where 'JVM' is inappropriate.
Now complete. CC @Glavo |
JVM
and Java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR unifies terminology usage between "JVM" and "Java" across localization files, ensuring Chinese uses "Java 虚拟机" appropriately while other languages use either "JVM" or "Java" where more suitable.
- Replaced instances of "Java 虚拟机" with "Java" in contexts referring to the runtime version.
- Updated non–Chinese languages to use "JVM" for VM setting labels and related messages, except where "Java" is clearer.
- Adjusted prompts and error messages in zh_CN, zh, ru, es, and default locale files to match the new terminology.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
I18N_zh_CN.properties | Refined "Java 虚拟机" vs "Java" usage; updated SSL, JVM memory, JDK version messages |
I18N_zh.properties | Same terminology updates for traditional Chinese |
I18N_ru.properties | Switched "Java VM" labels and prompts to "JVM" |
I18N_es.properties | Standardized "JVM" usage in settings; refined "Java" contexts |
I18N.properties | Unified default English to use "JVM" or "Java" as appropriate |
Comments suppressed due to low confidence (2)
HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties:485
- [nitpick] The phrase '更换为使用 Hotspot 虚拟机的 Java' reads awkwardly. Consider reordering to '更换为使用 Hotspot Java 虚拟机' for clarity and consistency.
game.crash.reason.openj9=当前游戏无法在 OpenJ9 虚拟机上运行。请你在“(全局/版本特定) 游戏设置 → 游戏 Java”中更换为使用 Hotspot 虚拟机的 Java,并重新启动游戏。如果没有下载安装,你可以在网上自行下载。
HMCL/src/main/resources/assets/lang/I18N_zh.properties:475
- [nitpick] The wording '更換為使用 Hotspot 虛擬機的 Java' is confusing. It’s clearer to say '更換為使用 Hotspot Java 虛擬機'.
game.crash.reason.openj9=目前遊戲無法執行在 OpenJ9 虛擬機上。請你在「(全域/實例特定) 遊戲設定 → 遊戲 Java」中更換為使用 Hotspot 虛擬機的 Java,並重新啟動遊戲。如果沒有下載安裝,你可以在網路上自行下載。
Uh oh!
There was an error while loading. Please reload this page.