添加输出游戏调试日志选项 #4144
Open
添加输出游戏调试日志选项 #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3gf8jv4dv
suggested changes
Jul 29, 2025
|
关于 log4j，我们正在考虑是否可以不再打包 log4j2.xml，而是遵循默认的配置。 |
Co-authored-by: 3gf8jv4dv <[email protected]>
burningtnt
approved these changes
Sep 1, 2025
|
我觉得这个选项名字不是很好，叫「输出调试日志」可能会更合适。而且我感觉它应该放在「查看日志」的下面，而不是高级选项里。 |
Glavo
reviewed
Sep 18, 2025
| FXUtils.unbind(txtServerIP, lastVersionSetting.serverIpProperty()); | ||
| chkAutoAllocate.selectedProperty().unbindBidirectional(lastVersionSetting.autoMemoryProperty()); | ||
| chkFullscreen.selectedProperty().unbindBidirectional(lastVersionSetting.fullscreenProperty()); | ||
| useDebugLogOutputPane.selectedProperty().unbindBidirectional(versionSetting.useDebugLogOutputProperty()); |
There was a problem hiding this comment.
你这里 unbind 错东西了。unbind 的目标应该是 lastVersionSetting 的属性，而不是 versionSetting 的属性 。
# Conflicts: # HMCLCore/src/main/java/org/jackhuang/hmcl/launch/DefaultLauncher.java
Glavo
reviewed
Sep 18, 2025
| InputStream source; | ||
| if (GameVersionNumber.asGameVersion(repository.getGameVersion(version)).compareTo("1.12") < 0) { | ||
| if (options.isShowDebugLog()) { | ||
| source = DefaultLauncher.class.getResourceAsStream("/assets/game/log4j2-debug.xml"); |
There was a problem hiding this comment.
你确定你的这个配置文件对 Minecraft 1.7+ 都生效吗？我怎么看到这个文件里用了高版本 Log4j 才有的功能？
Glavo
reviewed
Sep 27, 2025
| String sourcePath = "/assets/game/log4j2-"; | ||
|
|
||
| if (GameVersionNumber.asGameVersion(repository.getGameVersion(version)).compareTo("1.12") < 0) { | ||
| sourcePath += "1.7"; |
There was a problem hiding this comment.
不建议使用 += 拼接字符串，应当用 StringBuilder 来拼接。
3gf8jv4dv
suggested changes
Oct 3, 2025
Co-authored-by: 3gf8jv4dv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在崩溃群排查错误的过程中，因为 HMCL 给游戏提供的
log4j2.xml可能会丢失一些需要的信息，需要用户手动替换一个日志级别低的 log4j2 文件让用户自己操作非常容易出错且沟通成本高，因此需要一个快捷选项方便用户使用。本 PR 在游戏高级设置里添加了相关选项，可以一键切换到预设的低级别 log4j2 配置文件
