-
Notifications
You must be signed in to change notification settings - Fork 776
Admin checker #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Admin checker #4393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
怀疑本 PR 的必要性
java.util.Scanner scanner = new java.util.Scanner(process.getInputStream()); | ||
String uid = scanner.hasNext() ? scanner.next() : ""; | ||
scanner.close(); | ||
process.waitFor(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这会在 HMCL 的关键启动路径上阻塞地等待外部程序,会严重拖慢启动速度。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此需求由报错群成员提出,用于判断一些运行问题权限问题是否由用户使用了管理员权限但又不承认,如果你认为实现的不妥可以讲讲我应该怎么做或给出你的方案
For : #4392