Skip to content

Conversation

ShulkerSakura
Copy link
Contributor

For : #4392

Copy link
Member

@burningtnt burningtnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

怀疑本 PR 的必要性

java.util.Scanner scanner = new java.util.Scanner(process.getInputStream());
String uid = scanner.hasNext() ? scanner.next() : "";
scanner.close();
process.waitFor();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这会在 HMCL 的关键启动路径上阻塞地等待外部程序,会严重拖慢启动速度。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此需求由报错群成员提出,用于判断一些运行问题权限问题是否由用户使用了管理员权限但又不承认,如果你认为实现的不妥可以讲讲我应该怎么做或给出你的方案

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants