Fix unintended writes #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the connection is only established to test authentication, attribute types are never used and we don't need to retrieve them
This corresponds better what happens for multi-value attributes, where an empty set is returned
Some multi-value attributes were written although they where never changed. Accessing them created an empty set, which is different from the old value None. This unintented writing caused errors, when the user only has permission to read the attribute. The test-suite was updated to use a none-admin user for testing.
Member
There was a problem hiding this comment.
This file should not be part of this PR :-P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unintended writes caused by reading a multi-value attribute.
Reported by @No-L