-
Notifications
You must be signed in to change notification settings - Fork 2
Hero Mostly Finished #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hero Mostly Finished #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing some stuff mentioned in the issue
- the countdown you've built is the DOE counter, which will be released on DOE. Until DOE, the HackerHub counts down the days left for DOE. so keep the DOE counter component but replace it w the day count down in the IndexHeroContent component. The figma has a frame which says "Until DOE 30 days" in place of the counter, that's the day count down we'll release rn. Check the issue, there was an image for that there.
- The play/pause button is missing a tooltip, check the issue description.
other feedback:
- the grass and the message for early hackers overlaps for 1600+ px screens. The vinyl box and the grass also overlap for 650-768px.
- missing the text "coming soon" between the vinyl and the play/pause button in mobile.
- the counter does not have the same spacing from the left and right edge as the rest of the section as screen size approached 320px, it's extending beyond the visual margins. (see image below)
- i think the numbers under SECONDS on the counter are not centered and it makes the entire timestamp look slightly off-center.
|
For the in progress text, it's not there on desktop views. I'm not sure if we need to add it in only on mobile. If the music player works should we just not have the in progress text? |
|
by in progress text do you mean the "coming soon" text? it's not there on desktop bc we have the under construction section which we dont have on the mobile. so the text replaces that whole under construction message. ill merge the PR in for now, but we'll need to add that in |

The background isn't fully done:
The record player doesn't actually play music it just spins for now