Skip to content

Conversation

@Austin2Shih
Copy link
Collaborator

The background isn't fully done:

  • some stars are missing
  • tablet-l and below clouds are slightly misplaced

The record player doesn't actually play music it just spins for now

@JayJ104 JayJ104 linked an issue Feb 24, 2025 that may be closed by this pull request
Copy link
Contributor

@JayJ104 JayJ104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing some stuff mentioned in the issue

  1. the countdown you've built is the DOE counter, which will be released on DOE. Until DOE, the HackerHub counts down the days left for DOE. so keep the DOE counter component but replace it w the day count down in the IndexHeroContent component. The figma has a frame which says "Until DOE 30 days" in place of the counter, that's the day count down we'll release rn. Check the issue, there was an image for that there.
  2. The play/pause button is missing a tooltip, check the issue description.

other feedback:

  1. the grass and the message for early hackers overlaps for 1600+ px screens. The vinyl box and the grass also overlap for 650-768px.
  2. missing the text "coming soon" between the vinyl and the play/pause button in mobile.
  3. the counter does not have the same spacing from the left and right edge as the rest of the section as screen size approached 320px, it's extending beyond the visual margins. (see image below)
  4. i think the numbers under SECONDS on the counter are not centered and it makes the entire timestamp look slightly off-center.

image

@Austin2Shih
Copy link
Collaborator Author

For the in progress text, it's not there on desktop views. I'm not sure if we need to add it in only on mobile. If the music player works should we just not have the in progress text?

@JayJ104
Copy link
Contributor

JayJ104 commented Feb 25, 2025

by in progress text do you mean the "coming soon" text? it's not there on desktop bc we have the under construction section which we dont have on the mobile. so the text replaces that whole under construction message. ill merge the PR in for now, but we'll need to add that in

@JayJ104 JayJ104 self-requested a review February 25, 2025 03:13
@JayJ104 JayJ104 merged commit 47b74a9 into main Feb 25, 2025
2 checks passed
@JayJ104 JayJ104 deleted the feat/hero-section branch February 25, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hub: count down hero section

3 participants